0004812: Dereferencing pointer before null-check

ID	Project	Category	View Status	Date Submitted	Last Update

0004812	ardour	bugs	public	2012-04-04 23:41	2020-04-19 20:16

Reporter	ahurst	Assigned To	cth103
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version	3.0-beta3
Target Version	3.0

Summary	0004812: Dereferencing pointer before null-check
Description	Medium impact static analysis bug: A pointer is dereferenced before it is null-checked at gtk2_ardour/sfdb_freesound_mootcher.cc:189. Line 187 could be placed inside the conditional right below it.
Additional Information	*** Dereferencing pointer "xml_page.memory". The std::string operator=(char ) will dereference the right hand side to copy the string. 187 result = xml_page.memory; 188 // free the memory ** Null-checking "xml_page.memory" suggests that it may be actually be null, in which case the above will cause a crash. 189 if(xml_page.memory){ 190 free( xml_page.memory ); 191 xml_page.memory = NULL; 192 xml_page.size = 0; 193 }
Tags	No tags attached.

Date Modified	Username	Field	Change
2012-04-04 23:41	ahurst	New Issue
2012-04-05 01:12	cth103	cost	=> 0.00
2012-04-05 01:12	cth103	Target Version	=> 3.0 beta4
2012-04-07 02:08	cth103	Note Added: 0013091
2012-04-07 02:08	cth103	Status	new => resolved
2012-04-07 02:08	cth103	Resolution	open => fixed
2012-04-07 02:08	cth103	Assigned To	=> cth103
2012-05-23 15:08	cth103	Target Version	3.0 beta4 => 3.0
2020-04-19 20:16	system	Note Added: 0023021
2020-04-19 20:16	system	Status	resolved => closed

cth103 2012-04-07 02:08 administrator ~0013091	SVN 11813.

system 2020-04-19 20:16 developer ~0023021	Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved.