View Issue Details

IDProjectCategoryView StatusLast Update
0004800ardourbugspublic2020-04-19 20:16
Reporterahurst Assigned Tocth103  
PrioritynormalSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version3.0-beta3 
Target Version3.0 
Summary0004800: Invalidated iterator used
DescriptionHigh impact static analysis bug:

An iterator is invalidated and then subsequently used at libs/pbd/convert.cc:20.

The next value should be stored and used similarly to the erase 10 lines above.
Additional Information*** Using invalid iterator "i" after events below.
202 for (string::iterator i = url.begin(); i != last; ) {
203
204 if (*i == '%') {
205
206 next = i;
207
208 url.erase (i);
209
210 i = next;
211 ++next;
212
213 if (isxdigit (*i) && isxdigit (*next)) {
214 /* replace first digit with char */
215 *i = int_from_hex (*i,*next);
216 ++i; /* points at 2nd of 2 digits */
*** "erase" invalidates iterator "i".
217 url.erase (i);
218 }
219 } else {
220 ++i;
221 }
*** Jumping back to the beginning of the loop
222 }
TagsNo tags attached.

Activities

cth103

2012-04-01 14:30

administrator   ~0013053

Fixed in SVN 11771.

system

2020-04-19 20:16

developer   ~0023012

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2012-03-28 00:12 ahurst New Issue
2012-03-28 12:24 cth103 cost => 0.00
2012-03-28 12:24 cth103 Fixed in Version => 3.0 beta4
2012-03-28 14:24 cth103 Fixed in Version 3.0 beta4 =>
2012-03-28 14:24 cth103 Target Version => 3.0 beta4
2012-04-01 14:30 cth103 Note Added: 0013053
2012-04-01 14:30 cth103 Status new => resolved
2012-04-01 14:30 cth103 Resolution open => fixed
2012-04-01 14:30 cth103 Assigned To => cth103
2012-05-23 15:08 cth103 Target Version 3.0 beta4 => 3.0
2020-04-19 20:16 system Note Added: 0023012
2020-04-19 20:16 system Status resolved => closed