View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004753ardourbugspublic2012-03-03 23:472020-04-19 20:16
Reporterroyvegard Assigned Tocth103  
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Target Version3.0 
Summary0004753: Possible to create illegal automation line
DescriptionIt is possible to create an illegal automation line. A line where the next point is behind the current point.

If you continue to move points Ardour will eventually crash. If you add a new control point the automation line will be "fixed".
Steps To Reproduce1. Create 3 automation points to make an automation line.
2. Select the first and last control points, leaving the middle point un-selected.
3. Drag the two selected points so that the last point is located before the middle point.

See screen shots.
TagsNo tags attached.

Activities

2012-03-03 23:47

 

ardour_ap_01.png (3,932 bytes)   
ardour_ap_01.png (3,932 bytes)   

2012-03-03 23:47

 

ardour_ap_02.png (4,596 bytes)   
ardour_ap_02.png (4,596 bytes)   

2012-04-07 07:18

 

4753.patch (389 bytes)    
diff --git a/gtk2_ardour/automation_line.cc b/gtk2_ardour/automation_line.cc
index 263fe29..fb656d4 100644
--- a/gtk2_ardour/automation_line.cc
+++ b/gtk2_ardour/automation_line.cc
@@ -580,6 +580,7 @@ AutomationLine::end_drag ()
 		new MementoCommand<AutomationList>(memento_command_binder (), 0, &alist->get_state())
 		);
 
+	reset ();
 	trackview.editor().session()->set_dirty ();
 }
4753.patch (389 bytes)   

royvegard

2012-04-07 07:21

reporter   ~0013092

I've uploaded a patch that resets the automation line on end_drag.

royvegard

2012-05-31 18:58

reporter   ~0013337

This seems to be fixed as of 12511 (probably earlier). I can no longer create an illegal automation line. My patch is not needed, and I think this can be marked as resolved.

cth103

2012-05-31 20:24

administrator   ~0013338

Great, thanks!

system

2020-04-19 20:16

developer   ~0022983

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2012-03-03 23:47 royvegard New Issue
2012-03-03 23:47 royvegard File Added: ardour_ap_01.png
2012-03-03 23:47 royvegard File Added: ardour_ap_02.png
2012-03-03 23:50 cth103 cost => 0.00
2012-03-03 23:50 cth103 Target Version => 3.0 beta4
2012-03-03 23:53 cth103 Status new => confirmed
2012-04-07 07:18 royvegard File Added: 4753.patch
2012-04-07 07:21 royvegard Note Added: 0013092
2012-05-23 15:08 cth103 Target Version 3.0 beta4 => 3.0
2012-05-31 18:58 royvegard Note Added: 0013337
2012-05-31 20:24 cth103 Note Added: 0013338
2012-05-31 20:24 cth103 Status confirmed => resolved
2012-05-31 20:24 cth103 Resolution open => fixed
2012-05-31 20:24 cth103 Assigned To => cth103
2020-04-19 20:16 system Note Added: 0022983
2020-04-19 20:16 system Status resolved => closed