View Issue Details

IDProjectCategoryView StatusLast Update
0004702ardourbugspublic2015-09-18 15:19
Reportercolinf Assigned Tocth103  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Target Version3.0 
Summary0004702: [PATCH] Stereo panners move at half mouse speed
DescriptionWhen dragging on the 'L' or 'R' boxes of a stereo panner, the motion of the box doesn't follow the mouse exactly, but seems to travel only half the distance that the mouse is dragged.

This makes it quite difficult to make large adjustments to the panner in the editor mixer when it's close to the left edge of the screen, since dragging to the left can only move the 'L' or 'R' over half the width of the panner before the mouse cursor reaches the edge of the screen and can go no further.
TagsNo tags attached.

Activities

2012-03-23 17:18

 

stereo-panner-width-follow-mouse.patch (774 bytes)   
Index: gtk2_ardour/stereo_panner.cc
===================================================================
--- gtk2_ardour/stereo_panner.cc	(revision 11752)
+++ gtk2_ardour/stereo_panner.cc	(working copy)
@@ -469,8 +469,8 @@
 		return false;
 	}
 
-	int w = get_width();
-	double delta = (ev->x - last_drag_x) / (double) w;
+	int usable_width = get_width() - lr_box_size;
+	double delta = (ev->x - last_drag_x) / (double) usable_width;
 	double current_width = width_control->get_value ();
 
 	if (dragging_left) {
@@ -503,7 +503,8 @@
 			}
 
 		} else {
-			width_control->set_value (current_width + delta);
+			/* width needs to change by 2 * delta because both L & R move */
+			width_control->set_value (current_width + delta * 2);
 		}
 
 	} else if (dragging_position) {

colinf

2012-03-23 17:20

updater   ~0013012

Here's a small patch to make the 'L' or 'R' follow the mouse exactly when dragging to adjust the width of a stereo panner.

cth103

2012-03-23 22:56

administrator   ~0013013

Applied to SVN 11753.

colinf

2015-09-18 15:19

updater   ~0017296

Closing old issues reported by me: these have long since been fixed.

Issue History

Date Modified Username Field Change
2012-02-08 23:40 colinf New Issue
2012-02-09 20:21 cth103 cost => 0.00
2012-02-09 20:21 cth103 Target Version => 3.0-beta3
2012-02-14 17:20 paul Target Version 3.0-beta3 => 3.0 beta4
2012-03-23 17:18 colinf File Added: stereo-panner-width-follow-mouse.patch
2012-03-23 17:20 colinf Note Added: 0013012
2012-03-23 17:20 colinf Summary Steroe panners move at half mouse speed => [PATCH] Stereo panners move at half mouse speed
2012-03-23 22:56 cth103 Note Added: 0013013
2012-03-23 22:56 cth103 Status new => resolved
2012-03-23 22:56 cth103 Resolution open => fixed
2012-03-23 22:56 cth103 Assigned To => cth103
2012-05-23 15:08 cth103 Target Version 3.0 beta4 => 3.0
2015-09-18 15:19 colinf Note Added: 0017296
2015-09-18 15:19 colinf Status resolved => closed