View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004683 | ardour | bugs | public | 2012-02-02 17:03 | 2020-04-19 20:16 |
| Reporter | tophatdave | Assigned To | cth103 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0004683: MIDI note trim cursor incorrectly displayed when it shouldn't be | ||||
| Description | When hovering near the end of MIDI notes in the editor, the "trim" cursor is incorrectly displayed in several mouse modes | ||||
| Additional Information | i have attached a patch that normalizes the display of the trim cursor for the various mouse modes | ||||
| Tags | No tags attached. | ||||
|
2012-02-02 17:03
|
trimcursorpatch.txt (905 bytes)
Index: midi_region_view.cc
===================================================================
--- midi_region_view.cc (revision 11419)
+++ midi_region_view.cc (working copy)
@@ -3067,9 +3067,11 @@
{
Editor* editor = dynamic_cast<Editor*>(&trackview.editor());
- if (x_fraction > 0.0 && x_fraction < 0.2) {
+ Editing::MouseMode mm = editor->current_mouse_mode();
+ bool trimmable = (mm == MouseObject || mm == MouseTimeFX || mm == MouseRange);
+ if (trimmable && x_fraction > 0.0 && x_fraction < 0.2) {
editor->set_canvas_cursor (editor->cursors()->left_side_trim);
- } else if (x_fraction >= 0.8 && x_fraction < 1.0) {
+ } else if (trimmable && x_fraction >= 0.8 && x_fraction < 1.0) {
editor->set_canvas_cursor (editor->cursors()->right_side_trim);
} else {
if (pre_enter_cursor && can_set_cursor) {
|
|
|
Applied to SVN. Thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-02-02 17:03 | tophatdave | New Issue | |
| 2012-02-02 17:03 | tophatdave | File Added: trimcursorpatch.txt | |
| 2012-02-03 12:24 | cth103 | cost | => 0.00 |
| 2012-02-03 12:24 | cth103 | Note Added: 0012752 | |
| 2012-02-03 12:24 | cth103 | Status | new => resolved |
| 2012-02-03 12:24 | cth103 | Resolution | open => fixed |
| 2012-02-03 12:24 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:16 | system | Note Added: 0022954 | |
| 2020-04-19 20:16 | system | Status | resolved => closed |
