View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004502 | ardour | bugs | public | 2011-11-22 01:56 | 2020-04-19 20:15 |
| Reporter | acolomb | Assigned To | cth103 | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta2 | ||||
| Summary | 0004502: [PATCH] Underscore in plugin names is parsed | ||||
| Description | The "New plugin" menu in a processor box does not show plugin names containing and underscore correctly. This affects at least all guitarix_(amp,compressor,...) plugins. | ||||
| Additional Information | Attached patch prevents the underscore from being parsed as an accelerator key. | ||||
| Tags | No tags attached. | ||||
|
2011-11-22 01:56
|
plugin-underscores.patch (1,768 bytes)
Index: gtk2_ardour/plugin_selector.cc
===================================================================
--- gtk2_ardour/plugin_selector.cc (revision 10756)
+++ gtk2_ardour/plugin_selector.cc (working copy)
@@ -648,7 +648,9 @@
for (PluginInfoList::const_iterator i = all_plugs.begin(); i != all_plugs.end(); ++i) {
if (manager.get_status (*i) == PluginManager::Favorite) {
- favs->items().push_back (MenuElem ((*i)->name, (sigc::bind (sigc::mem_fun (*this, &PluginSelector::plugin_chosen_from_menu), *i))));
+ MenuElem elem((*i)->name, (sigc::bind (sigc::mem_fun (*this, &PluginSelector::plugin_chosen_from_menu), *i)));
+ elem.get_child()->set_use_underline(false);
+ favs->items().push_back (elem);
}
}
return favs;
@@ -690,7 +692,9 @@
creator_submenu_map.insert (pair<std::string,Menu*> (creator, submenu));
submenu->set_name("ArdourContextMenu");
}
- submenu->items().push_back (MenuElem ((*i)->name, (sigc::bind (sigc::mem_fun (*this, &PluginSelector::plugin_chosen_from_menu), *i))));
+ MenuElem elem((*i)->name, (sigc::bind (sigc::mem_fun (*this, &PluginSelector::plugin_chosen_from_menu), *i)));
+ elem.get_child()->set_use_underline(false);
+ submenu->items().push_back (elem);
}
return by_creator;
}
@@ -726,7 +730,9 @@
category_submenu_map.insert (pair<std::string,Menu*> (category, submenu));
submenu->set_name("ArdourContextMenu");
}
- submenu->items().push_back (MenuElem ((*i)->name, (sigc::bind (sigc::mem_fun (*this, &PluginSelector::plugin_chosen_from_menu), *i))));
+ MenuElem elem((*i)->name, (sigc::bind (sigc::mem_fun (*this, &PluginSelector::plugin_chosen_from_menu), *i)));
+ elem.get_child()->set_use_underline(false);
+ submenu->items().push_back (elem);
}
return by_category;
}
|
|
|
Applied to SVN 10766. Thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-22 01:56 | acolomb | New Issue | |
| 2011-11-22 01:56 | acolomb | File Added: plugin-underscores.patch | |
| 2011-11-22 02:37 | cth103 | cost | => 0.00 |
| 2011-11-22 02:37 | cth103 | Target Version | => 3.0-beta2 |
| 2011-11-22 12:12 | cth103 | Note Added: 0012180 | |
| 2011-11-22 12:12 | cth103 | Status | new => resolved |
| 2011-11-22 12:12 | cth103 | Resolution | open => fixed |
| 2011-11-22 12:12 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:15 | system | Note Added: 0022858 | |
| 2020-04-19 20:15 | system | Status | resolved => closed |
