View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004349 | ardour | bugs | public | 2011-10-03 19:48 | 2020-04-19 20:15 |
| Reporter | nightmorph | Assigned To | nettings | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | won't fix | ||
| Target Version | 3.0-beta1 | ||||
| Summary | 0004349: ardour 3: missing pkg-config check for libsoundtouch | ||||
| Description | ardour3's wscript is missing a pkg-config check for soundtouch. without this check it fails to detect the system's libsoundtouch every time it's built. patch is attached. | ||||
| Tags | No tags attached. | ||||
|
2011-10-03 19:48
|
ardour-soundtouch.patch (570 bytes)
Index: 3.0/wscript
===================================================================
--- 3.0/wscript
+++ 3.0/wscript
@@ -514,6 +514,7 @@
autowaf.check_pkg(conf, 'gthread-2.0', uselib_store='GTHREAD', atleast_version='2.2')
autowaf.check_pkg(conf, 'glibmm-2.4', uselib_store='GLIBMM', atleast_version='2.14.0')
autowaf.check_pkg(conf, 'sndfile', uselib_store='SNDFILE', atleast_version='1.0.18')
+ autowaf.check_pkg(conf, 'soundtouch', uselib_store='SOUNDTOUCH', atleast_version='1.6.0')
for i in children:
sub_config_and_use(conf, i)
|
|
|
There is a check for soundtouch-1.0 via pkg-config, but at least on my Debian system it is shipped as soundtouch.pc (without -1.0). Upstream soundtouch currently ships soundtouch.pc, so the wscript should probably be changed. Attaching a new patch to fix detection in libs/ardour/wscript rather than adding a new check in top-level wscript. Carl, is there a minimum version requirement of 1.6.0? |
|
2011-10-04 09:31
|
ardour-soundtouch.second.patch (680 bytes)
Index: libs/ardour/wscript
===================================================================
--- libs/ardour/wscript (revision 10187)
+++ libs/ardour/wscript (working copy)
@@ -259,7 +259,7 @@
if conf.is_defined('HAVE_LILV'):
autowaf.check_pkg(conf, 'suil-0', uselib_store='SUIL',
atleast_version='0.2.0', mandatory=False)
- autowaf.check_pkg(conf, 'soundtouch-1.0', uselib_store='SOUNDTOUCH',
+ autowaf.check_pkg(conf, 'soundtouch', uselib_store='SOUNDTOUCH',
mandatory=False)
autowaf.check_pkg(conf, 'cppunit', uselib_store='CPPUNIT',
atleast_version='1.12.0', mandatory=False)
|
|
|
I thought ardour3 no longer used soundtouch, at least it isn't linked to it anymore. |
|
|
yup. right after i filed this bug, the folks on #ardour told me that the references to soundtouch are leftovers; it's cruft that can and should be removed soon. ardour3 doesn't use soundtouch. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-10-03 19:48 | nightmorph | New Issue | |
| 2011-10-03 19:48 | nightmorph | File Added: ardour-soundtouch.patch | |
| 2011-10-03 21:33 | cth103 | cost | => 0.00 |
| 2011-10-03 21:33 | cth103 | Target Version | => 3.0-beta1 |
| 2011-10-04 09:31 | acolomb | Note Added: 0011641 | |
| 2011-10-04 09:31 | acolomb | File Added: ardour-soundtouch.second.patch | |
| 2011-10-04 09:33 | acolomb | Note Edited: 0011641 | |
| 2011-10-04 15:54 | orbisvicis | Note Added: 0011643 | |
| 2011-10-04 16:26 | nightmorph | Note Added: 0011645 | |
| 2011-10-28 00:56 | nettings | Status | new => resolved |
| 2011-10-28 00:56 | nettings | Resolution | open => won't fix |
| 2011-10-28 00:56 | nettings | Assigned To | => nettings |
| 2011-10-28 01:07 | nettings | Relationship added | related to 0004403 |
| 2020-04-19 20:15 | system | Note Added: 0022761 | |
| 2020-04-19 20:15 | system | Status | resolved => closed |
