View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004249 | ardour | bugs | public | 2011-08-05 19:53 | 2020-04-19 20:15 |
| Reporter | royvegard | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta1 | ||||
| Summary | 0004249: Only obeys MMC commands sent from MMC Device ID 127 (broadcast) | ||||
| Description | Only MMC commands from device ID 127 are obeyed. | ||||
| Steps To Reproduce | 1. Configure your Midi controller to send MMCs with device ID other than 127. 2. Connect Midi controller to the MMC in port of Ardour. 3. Open Preferences window and select "Obey MIDI Machine Control commands" and set "Inbound MMC device ID" as in step 1. Ardour does not obey MMC commands. 4. Configure Midi controller with device ID 127. Ardour obeys MMC commands. | ||||
| Additional Information | Ardour's Midi Tracer displays the MMC messages no matter what device ID they have. | ||||
| Tags | No tags attached. | ||||
|
|
Did you check Inbound MMC device ID one above or below what your device is sending? |
|
|
Yes, and I noticed that max inbound and outbound MMC device ID is 128. I believe 127 should be the max value. |
|
2011-08-12 22:08
|
4249.diff (759 bytes)
Index: libs/ardour/session_state.cc
===================================================================
--- libs/ardour/session_state.cc (revision 9983)
+++ libs/ardour/session_state.cc (working copy)
@@ -3453,11 +3453,11 @@ Session::config_changed (std::string p, bool ours)
//poke_midi_thread ();
- } else if (p == "mmc-device-id" || p == "mmc-receive-id") {
+ } else if (p == "mmc-device-id" || p == "mmc-receive-id" || p == "mmc-receive-device-id") {
MIDI::Manager::instance()->mmc()->set_receive_device_id (Config->get_mmc_receive_device_id());
- } else if (p == "mmc-send-id") {
+ } else if (p == "mmc-send-id" || p == "mmc-send-device-id") {
MIDI::Manager::instance()->mmc()->set_send_device_id (Config->get_mmc_send_device_id());
|
|
|
Patch attached. Please commit. |
|
|
committed as part (!) of rev 9985 |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-08-05 19:53 | royvegard | New Issue | |
| 2011-08-08 10:44 | cth103 | cost | => 0.00 |
| 2011-08-08 10:44 | cth103 | Target Version | => 3.0-beta1 |
| 2011-08-09 16:32 | paul | Note Added: 0011272 | |
| 2011-08-09 16:32 | paul | Status | new => feedback |
| 2011-08-09 20:12 | royvegard | Note Added: 0011281 | |
| 2011-08-12 22:08 | royvegard | File Added: 4249.diff | |
| 2011-08-12 22:10 | royvegard | Note Added: 0011321 | |
| 2011-08-13 16:28 | paul | Note Added: 0011327 | |
| 2011-08-13 16:28 | paul | Status | feedback => resolved |
| 2011-08-13 16:28 | paul | Resolution | open => fixed |
| 2011-08-13 16:28 | paul | Assigned To | => paul |
| 2020-04-19 20:15 | system | Note Added: 0022705 | |
| 2020-04-19 20:15 | system | Status | resolved => closed |
