View Issue Details

IDProjectCategoryView StatusLast Update
0004242ardourbugspublic2020-04-19 20:15
Reporterdeva Assigned Topaul  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Target Version3.0-beta1 
Summary0004242: assertion in append_note_on_unlocked.
DescriptionAn assertion on session load:
ardour-3.0: ../libs/evoral/src/Sequence.cpp:877: void Evoral::Sequence<Time>::append_note_on_unlocked(boost::shared_ptr<Evoral::Note<Time> >, Evoral::event_id_t) [with Time = double]: Assertion `note->note() <= 127' failed.

See attached project for example. The assertion happens in SVN revision 9942.
TagsNo tags attached.

Activities

2011-07-30 08:50

 

assert_example.tar.gz (13,722 bytes)

paul

2011-08-11 15:48

administrator   ~0011293

where did Drums-1.mid come from? It has an illegal note value stored within it. Did Ardour record this or was it imported?

deva

2011-08-11 15:56

reporter   ~0011294

Both .mid files are 'drawn' with Ardour.

paul

2011-08-11 16:22

administrator   ~0011295

svn rev 9979 will no longer crash when loading this session, but we still need to determine where the incorrect data came from in the first place.

deva

2011-08-11 17:33

reporter   ~0011299

I can reproduce the assert by drawing a note with the midi pencil tool and then (still with the pencil tool) dragging the note down below "C-1(0)" to "???(-1)".
This makes the note disappear from the view while still stored in the midi file.

paul

2011-08-12 14:43

administrator   ~0011309

rev 9983 now contains fixes to prevent note drags (and other operations) from creating illegal note numbers, velocities and channels. i believe that should be considered the fix for this bug.

thanks for your help in reporting a very nice clear case to work with.

deva

2011-08-12 15:23

reporter   ~0011310

Fix confirmed. I agree that the note clamp is the correct way to fix this bug.

paul

2011-08-12 15:41

administrator   ~0011312

see notes.

system

2020-04-19 20:15

developer   ~0022700

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2011-07-30 08:50 deva New Issue
2011-07-30 08:50 deva File Added: assert_example.tar.gz
2011-07-31 00:40 cth103 cost => 0.00
2011-07-31 00:40 cth103 Target Version => 3.0-beta1
2011-08-11 15:48 paul Note Added: 0011293
2011-08-11 15:48 paul Status new => feedback
2011-08-11 15:56 deva Note Added: 0011294
2011-08-11 16:22 paul Note Added: 0011295
2011-08-11 17:33 deva Note Added: 0011299
2011-08-12 14:43 paul Note Added: 0011309
2011-08-12 15:24 deva Note Added: 0011310
2011-08-12 15:41 paul Note Added: 0011312
2011-08-12 15:41 paul Status feedback => resolved
2011-08-12 15:41 paul Resolution open => fixed
2011-08-12 15:41 paul Assigned To => paul
2020-04-19 20:15 system Note Added: 0022700
2020-04-19 20:15 system Status resolved => closed