View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004223 | ardour | bugs | public | 2011-07-23 14:56 | 2011-08-14 09:53 |
| Reporter | oofus | Assigned To | cth103 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Dell D830 core2duo T9300 2.5GHz | OS | Kubuntu | OS Version | 10.10 |
| Target Version | 3.0-beta1 | ||||
| Summary | 0004223: When naming tracks in the editor and tabbing to the next one, tracks off the bootom of the view should be brought into view. | ||||
| Description | When naming tracks in the editor and tabbing to the next one, tracks off the bottom of the view should be brought into view as they are tabbed to. | ||||
| Tags | No tags attached. | ||||
|
|
svn rev 9924 has an attempt at the correct behaviour |
|
|
Not quite right yet: the tabbed-to track is only brought into view if the top of the track is lower than the bottom of the editor window, so if the upper part of a track is visible at the bottom of the window, tabbing to it doesn't scroll the track name into view. I guess the track's height should be taken into account too so that when tabbing downwards the bottom of the tabbed-to track is brought into view. |
|
|
Actually, if the tabbed-to track is off the bottom of the editor window, it will only be scrolled into view if is further below the bottom of the window than the height of whichever of the the 'Meter', 'Tempo', 'Ranges' etc. strips are visible at the top of the editor view. |
|
2011-07-26 16:10
|
4223.patch (541 bytes)
Index: gtk2_ardour/editor_canvas.cc
===================================================================
--- gtk2_ardour/editor_canvas.cc (revision 9936)
+++ gtk2_ardour/editor_canvas.cc (working copy)
@@ -704,7 +704,7 @@
double v = vertical_adjustment.get_value ();
- if (begin < v || begin > v + _canvas_height) {
+ if (begin < v || begin + tav.current_height() > v + _canvas_height - canvas_timebars_vsize) {
/* try to put the TimeAxisView roughly central */
if (begin >= _canvas_height/2.0) {
begin -= _canvas_height/2.0;
|
|
|
I think the attached 4223.patch makes this work a bit better... |
|
|
Colin's patch applied to SVN 9952; please re-open this bug if there are still problems. Thanks! |
|
|
That's pretty good now, thanks. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-07-23 14:56 | oofus | New Issue | |
| 2011-07-23 14:56 | oofus | cost | => 0.00 |
| 2011-07-24 20:15 | cth103 | Target Version | => 3.0-beta1 |
| 2011-07-25 20:29 | paul | Note Added: 0011221 | |
| 2011-07-25 23:47 | colinf | Note Added: 0011222 | |
| 2011-07-26 16:10 | colinf | Note Added: 0011224 | |
| 2011-07-26 16:10 | colinf | File Added: 4223.patch | |
| 2011-07-26 16:11 | colinf | Note Added: 0011225 | |
| 2011-08-03 13:28 | cth103 | Note Added: 0011247 | |
| 2011-08-03 13:28 | cth103 | Status | new => resolved |
| 2011-08-03 13:28 | cth103 | Resolution | open => fixed |
| 2011-08-03 13:28 | cth103 | Assigned To | => cth103 |
| 2011-08-14 09:53 | oofus | Note Added: 0011336 | |
| 2011-08-14 09:53 | oofus | Status | resolved => closed |
