View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004033 | ardour | bugs | public | 2011-05-09 02:18 | 2020-04-19 20:15 |
| Reporter | thefoxbox | Assigned To | cth103 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta2 | ||||
| Summary | 0004033: Transport does not stop at end of session | ||||
| Description | rev 9486 The transport preference "Stop at the end of the session" does not have any effect on transport. | ||||
| Tags | No tags attached. | ||||
|
|
This issue appears to be resolved with svn 9486. I filed the bug report against the version I had installed vs. the version I had checked out. Sorry about that. |
|
|
OK, no worries. |
|
|
rev 9509 I was able to figure out how to reproduce this: 1. create new session 2. add mono audio track 3. add punch-in/out range 4. enable punch-in/out 5. enable record on Audio 1 and transport and roll After start end markers are created, move the end marker any distance past the punch-out marker. With punch-in/out enabled, the transport will roll past the end marker even when "Stop at the end of the session" preference is selected. Disable punch-in and the transport stops at the end marker. |
|
|
For your consideration: Currently "Stop at the end of the session" appears to work as such: Punch-in enabled + Punch-out enabled, transport rolls past end marker. Punch-in disabled + Punch-out enabled, transport stops at end marker. Instead, the opposite may make more sense. You may want to punch-in and record past the end marker: Punch-in enabled + Punch-out enabled, transport stops at end of session. Punch-in enabled + Punch-out disabled, transport rolls past end marker. |
|
|
It seems to me that stop-at-session-end should never happen if there there is an active punch in or out. Any thoughts? |
|
2011-05-21 19:03
|
4033.patch (669 bytes)
diff --git a/libs/ardour/session_process.cc b/libs/ardour/session_process.cc
index 6911a5e..8de0620 100644
--- a/libs/ardour/session_process.cc
+++ b/libs/ardour/session_process.cc
@@ -1147,7 +1147,8 @@ Session::process_event (SessionEvent* ev)
framepos_t
Session::compute_stop_limit () const
{
- bool const punching = (config.get_punch_in () && _locations->auto_punch_location());
+ /* Never stop at session end if we are punching */
+ bool const punching = ((config.get_punch_in() || config.get_punch_out()) && _locations->auto_punch_location());
if (!actively_recording() && !punching && Config->get_stop_at_session_end()) {
return current_end_frame ();
|
|
|
What if punch out is enabled, but occurs before the end of session? Would it make sense to roll the transport past the end when it is not armed for recording? |
|
|
SVN 10978 has the following logic: If stop-at-session-end is set, we follow it unless: 1. we are recording 2. punch in is on but punch out is off 3. punch in and out are on, but the punch out point is beyond session end Please leave comments on the bug if you dislike this arrangement! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-05-09 02:18 | thefoxbox | New Issue | |
| 2011-05-09 06:15 | thefoxbox | Note Added: 0010708 | |
| 2011-05-09 09:59 | cth103 | cost | => 0.00 |
| 2011-05-09 09:59 | cth103 | Note Added: 0010709 | |
| 2011-05-09 09:59 | cth103 | Status | new => resolved |
| 2011-05-09 09:59 | cth103 | Resolution | open => no change required |
| 2011-05-09 09:59 | cth103 | Assigned To | => cth103 |
| 2011-05-15 04:19 | thefoxbox | Note Added: 0010744 | |
| 2011-05-15 04:19 | thefoxbox | Note Edited: 0010744 | |
| 2011-05-16 19:22 | thefoxbox | Note Added: 0010756 | |
| 2011-05-16 19:23 | thefoxbox | Status | resolved => feedback |
| 2011-05-16 19:23 | thefoxbox | Resolution | no change required => reopened |
| 2011-05-16 22:35 | cth103 | Target Version | => 3.0-beta1 |
| 2011-05-21 19:01 | cth103 | Note Added: 0010783 | |
| 2011-05-21 19:03 | cth103 | File Added: 4033.patch | |
| 2011-05-23 16:45 | thefoxbox | Note Added: 0010790 | |
| 2011-11-15 17:20 | cth103 | Target Version | 3.0-beta1 => 3.0-beta2 |
| 2011-12-11 16:27 | cth103 | Note Added: 0012369 | |
| 2011-12-11 16:27 | cth103 | Status | feedback => resolved |
| 2011-12-11 16:27 | cth103 | Resolution | reopened => fixed |
| 2020-04-19 20:15 | system | Note Added: 0022574 | |
| 2020-04-19 20:15 | system | Status | resolved => closed |
