View Issue Details

IDProjectCategoryView StatusLast Update
0003880ardourbugspublic2020-04-19 20:15
Reporterdanboid Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.0-alpha2 
Target Version3.0-beta1 
Summary0003880: MIDI automation doesn't work on first playback
DescriptionMIDI automation tracks don't work on first playback.

32bit alpha2 under AV Linux
TagsNo tags attached.

Activities

danboid

2011-04-07 15:36

reporter   ~0010505

Last edited: 2011-04-07 15:37

Bug still applies under alpha4 32bit

cth103

2011-09-07 15:27

administrator   ~0011459

Can you still reproduce this Dan?

danboid

2011-09-10 12:29

reporter   ~0011479

Yep - just tried again twice under 10067 and MIDI automation doesn't take effect until second playback still.

cth103

2011-09-12 11:56

administrator   ~0011485

I still can't reproduce it. Is there a session which you can provide which always exhibits the problem on load?

danboid

2011-09-16 17:21

reporter   ~0011532

Sorry for not being verbose enough on this but at least I've pinned this down now enough to give you a real chance of reproducing it like I just have under 10067/AV5.

The automation only fails on the first playback when the MIDI region was created with the grid setting at 'bars' and the region was created starting at/from 0 on the timeline. It doesn't matter if you have a note starting at 0 either - automation still fails on first play for such regions.

cth103

2011-09-17 23:48

administrator   ~0011534

Great, thanks, that's reproducible. The attached patch fixes it, I think, but we just need to check that it's right.

2011-09-17 23:49

 

3880.patch (1,456 bytes)   
diff --git a/libs/ardour/ardour/midi_model.h b/libs/ardour/ardour/midi_model.h
index 1479bdc..d0a05e1 100644
--- a/libs/ardour/ardour/midi_model.h
+++ b/libs/ardour/ardour/midi_model.h
@@ -289,6 +289,8 @@ private:
 	void control_list_interpolation_changed (Evoral::Parameter, Evoral::ControlList::InterpolationStyle);
 	void automation_list_automation_state_changed (Evoral::Parameter, AutoState);
 
+	void control_list_marked_dirty ();
+
 	PBD::ScopedConnectionList _midi_source_connections;
 
 	// We cannot use a boost::shared_ptr here to avoid a retain cycle
diff --git a/libs/ardour/midi_model.cc b/libs/ardour/midi_model.cc
index ce357dc..039b44e 100644
--- a/libs/ardour/midi_model.cc
+++ b/libs/ardour/midi_model.cc
@@ -1946,3 +1946,9 @@ MidiModel::transpose (TimeType from, TimeType to, int semitones)
 
 	apply_command (s->session (), c);
 }
+
+void
+MidiModel::control_list_marked_dirty ()
+{
+	ContentsChanged (); /* EMIT SIGNAL */
+}
diff --git a/libs/evoral/evoral/Sequence.hpp b/libs/evoral/evoral/Sequence.hpp
index 98d4b19..bc3831d 100644
--- a/libs/evoral/evoral/Sequence.hpp
+++ b/libs/evoral/evoral/Sequence.hpp
@@ -313,7 +313,7 @@ private:
 	void get_notes_by_pitch (Notes&, NoteOperator, uint8_t val, int chan_mask = 0) const;
 	void get_notes_by_velocity (Notes&, NoteOperator, uint8_t val, int chan_mask = 0) const;
 
-	void control_list_marked_dirty ();
+	virtual void control_list_marked_dirty ();
 
 	const TypeMap& _type_map;
 
3880.patch (1,456 bytes)   

cth103

2011-09-19 17:16

administrator   ~0011539

Should be fixed in SVN 10095.

system

2020-04-19 20:15

developer   ~0022468

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2011-03-25 12:10 danboid New Issue
2011-03-25 16:41 cth103 cost => 0.00
2011-03-25 16:41 cth103 Target Version => 3.0-beta1
2011-04-07 15:36 danboid Note Added: 0010505
2011-04-07 15:37 danboid Note Edited: 0010505
2011-04-21 01:04 cth103 Status new => confirmed
2011-09-07 15:27 cth103 Note Added: 0011459
2011-09-07 15:27 cth103 Status confirmed => feedback
2011-09-10 12:29 danboid Note Added: 0011479
2011-09-12 11:56 cth103 Note Added: 0011485
2011-09-16 17:21 danboid Note Added: 0011532
2011-09-17 23:48 cth103 Note Added: 0011534
2011-09-17 23:48 cth103 Status feedback => confirmed
2011-09-17 23:49 cth103 File Added: 3880.patch
2011-09-19 17:16 cth103 Note Added: 0011539
2011-09-19 17:16 cth103 Status confirmed => resolved
2011-09-19 17:16 cth103 Resolution open => fixed
2011-09-19 17:16 cth103 Assigned To => cth103
2020-04-19 20:15 system Note Added: 0022468
2020-04-19 20:15 system Status resolved => closed