View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003868 | ardour | bugs | public | 2011-03-22 20:34 | 2020-04-19 20:15 |
| Reporter | v2 | Assigned To | v2 | ||
| Priority | urgent | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0-alpha1 | ||||
| Target Version | 3.0-beta1 | ||||
| Summary | 0003868: Recording on a MIDI track causes a crash | ||||
| Description | Recording on a MIDI track crashes Ardour. 1. Create a new session 2. Create a MIDI track 3. Arm track 4. Rec-enable & start transport 5. Stop transport 6. Rec-enable & start transport 7. crash The track had no MIDI input connections nor any regions appeared on the track on steps 4-7. | ||||
| Additional Information | Jack 0.120.2 jackd -d alsa -n 3 | ||||
| Tags | No tags attached. | ||||
|
2011-03-22 23:18
|
midi__source_port_check.diff (615 bytes)
Index: libs/ardour/midi_diskstream.cc
===================================================================
--- libs/ardour/midi_diskstream.cc (revision 9187)
+++ libs/ardour/midi_diskstream.cc (working copy)
@@ -529,7 +529,13 @@
}
if (nominally_recording || rec_nframes) {
+ if (!_source_port)
+ get_input_sources();
+ /* FIXME: throw a warning of some sort? */
+ if (!_source_port)
+ return 1;
+
// Pump entire port buffer into the ring buffer (FIXME: split cycles?)
MidiBuffer& buf = _source_port->get_midi_buffer(nframes);
for (MidiBuffer::iterator i = buf.begin(); i != buf.end(); ++i) {
|
|
|
On my end, Ardour crashed after step 4. Ardour crashed because the variable _source_port was not initialized when the track has no MIDI input connections. The attached patch just makes a check if the variable is initialized or not (it tries to initialize it if its not), which seems to solve the problem. |
|
|
are either of you using the "manually connect tracks and busses" option? |
|
|
I'm not. If it is of interest my options under "Connection of tracks and busses" is: [x] Auto-connect master/monitor busses Connect track inputs: "automatically to physical inputs" Connect track and bus outputs: "automatically to master bus" As previously stated: the patch I submitted solved the problem, at least for me. (perhaps it only removes the symptoms, and the real problem should be solved elsewhere) |
|
|
I have the same parameters as Joskar. For what it's worth, I didn't change any defaults when A3 initially asked for the default parameters. This is still a problem with alpha3. |
|
|
.. And adding a MIDI input connection to the track definitely hides this issue. |
|
|
Has this patch been approved / committed to A3 yet? |
|
|
no, because its not the correct fix, just a band-aid. |
|
|
do you still need some extra information to help fix the issue? |
|
|
the correct fix for this should be in svn now. i'd appreciate feedback, because i couldn't make it misbehave here (mostly for practical reasons). |
|
|
A revision (forgot to mark down which one) from yesterday did not exhibit the crash anymore. Consider it fixed. Thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-03-22 20:34 | v2 | New Issue | |
| 2011-03-22 20:34 | v2 | cost | => 0.00 |
| 2011-03-22 23:18 | Joskar | File Added: midi__source_port_check.diff | |
| 2011-03-22 23:23 | Joskar | Note Added: 0010380 | |
| 2011-03-23 02:40 | cth103 | Target Version | => 3.0-beta1 |
| 2011-03-23 22:30 | paul | Note Added: 0010389 | |
| 2011-03-24 02:49 | Joskar | Note Added: 0010401 | |
| 2011-03-26 09:18 | v2 | Note Added: 0010418 | |
| 2011-03-26 09:26 | v2 | Note Added: 0010419 | |
| 2011-03-26 09:26 | v2 | Note Edited: 0010419 | |
| 2011-04-09 09:27 | v2 | Note Added: 0010527 | |
| 2011-04-09 13:04 | paul | Note Added: 0010528 | |
| 2011-04-09 13:06 | v2 | Note Added: 0010529 | |
| 2011-04-09 16:38 | paul | Note Added: 0010537 | |
| 2011-04-19 18:38 | v2 | Note Added: 0010598 | |
| 2011-04-19 18:38 | v2 | Status | new => resolved |
| 2011-04-19 18:38 | v2 | Resolution | open => fixed |
| 2011-04-19 18:38 | v2 | Assigned To | => v2 |
| 2020-04-19 20:15 | system | Note Added: 0022461 | |
| 2020-04-19 20:15 | system | Status | resolved => closed |
