View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003589 | ardour | bugs | public | 2010-12-06 02:15 | 2020-04-19 20:14 |
| Reporter | lincoln | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta1 | ||||
| Summary | 0003589: Mute not emitting signal for controllable | ||||
| Description | When a route is muted it is not emitting the signal for the controllable property. As a result muting is not showing up on the OSC client, and possibly other clients depending on this signal too. The attached patch adds the signalling. | ||||
| Tags | No tags attached. | ||||
|
2010-12-06 02:15
|
route-mute-signal-emit.patch (976 bytes)
Index: libs/ardour/route.cc
===================================================================
--- libs/ardour/route.cc (revision 8190)
+++ libs/ardour/route.cc (working copy)
@@ -108,7 +108,7 @@
/* add standard controls */
_solo_control->set_flags (Controllable::Flag (_solo_control->flags() | Controllable::Toggle));
- _mute_control->set_flags (Controllable::Flag (_solo_control->flags() | Controllable::Toggle));
+ _mute_control->set_flags (Controllable::Flag (_mute_control->flags() | Controllable::Toggle));
add_control (_solo_control);
add_control (_mute_control);
@@ -780,6 +780,7 @@
if (_mute_master->muted_by_self()) {
mute_changed (this); /* EMIT SIGNAL */
+ _mute_control->Changed (); /* EMIT SIGNAL */
}
}
@@ -794,6 +795,7 @@
if (muted() != yn) {
_mute_master->set_muted_by_self (yn);
mute_changed (src); /* EMIT SIGNAL */
+ _mute_control->Changed (); /* EMIT SIGNAL */
}
}
|
|
|
applied to svn, rev 8291 |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-12-06 02:15 | lincoln | New Issue | |
| 2010-12-06 02:15 | lincoln | File Added: route-mute-signal-emit.patch | |
| 2010-12-06 13:35 | cth103 | cost | => 0.00 |
| 2010-12-06 13:35 | cth103 | Resolution | open => reopened |
| 2010-12-06 13:35 | cth103 | Target Version | => 3.0-beta1 |
| 2010-12-17 04:14 | paul | Note Added: 0009648 | |
| 2010-12-17 04:14 | paul | Status | new => resolved |
| 2010-12-17 04:14 | paul | Resolution | reopened => fixed |
| 2010-12-17 04:14 | paul | Assigned To | => paul |
| 2020-04-19 20:14 | system | Note Added: 0022291 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
