View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003466 | ardour | bugs | public | 2010-09-20 14:27 | 2020-04-19 20:14 |
| Reporter | realhangman | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | random |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.8.11 | ||||
| Target Version | 2.8.12 | ||||
| Summary | 0003466: Region fade out gets randomly deactivated while editing | ||||
| Description | Hi, when I use the region fade out, it happens very often that the fade out gets deactivated after some editing. I then have to right-click the fade out and reactivate it. This is very troublesome when you have a lot of regions and suddenly something sounds bad - you have to check every region fade out. I'm experiencing this for a year now. First I thought it was my mistake, but I don't have a shortcut on it and don't deactivate it accidentally. I use the 'Most recently added regions are higher' editing mode, maybe it has something to do with it. Unfortunately, I don't know how to reproduce this. Maybe someone is experiencing something similar? Best Benjamin | ||||
| Additional Information | Ardour 2.8.11, it happens randomly but often with small and big projects. | ||||
| Tags | No tags attached. | ||||
|
|
Thanks a lot for adding this to target version 2.8.12. I've again tried hard to reproduce this and have found something strange that probably has something to do with my problem. Here is a link to a rather small session: http://www.septimbears.de/test-fadeout.tar.gz Don't care about the missing audio files, the 1 important file is in there, the region is at about 00:01:00 in the last audio track. There is a short fadeout at the end of it which is activated right now. If I deactivate it, save and reload the session, it's still activated! First, I had the problem that the fadeout was deactivated and the activation wasn't saved, now it's the other way round... Can someone try this session and confirm this? Thanks Benjamin |
|
2010-09-22 15:45
|
3466.patch (813 bytes)
diff --git a/libs/ardour/audioregion.cc b/libs/ardour/audioregion.cc
index 7130e52..1da2d1e 100644
--- a/libs/ardour/audioregion.cc
+++ b/libs/ardour/audioregion.cc
@@ -735,7 +735,7 @@ AudioRegion::state (bool full)
child->add_child_nocopy (_fade_in.get_state ());
}
- child->add_property (X_("active"), _fade_in_disabled ? X_("no") : X_("yes"));
+ child->add_property (X_("active"), (_flags & FadeIn) ? X_("yes") : X_("no"));
child = node.add_child (X_("FadeOut"));
@@ -745,7 +745,7 @@ AudioRegion::state (bool full)
child->add_child_nocopy (_fade_out.get_state ());
}
- child->add_property (X_("active"), _fade_out_disabled ? X_("no") : X_("yes"));
+ child->add_property (X_("active"), (_flags & FadeOut) ? X_("yes") : X_("no"));
}
child = node.add_child ("Envelope");
|
|
|
The attached patch fixes the issue in the comment, I believe. The code for managing fades is a little complicated so it's hard to know whether the patch will fix your wider problems, or maybe cause new problems ;) Would be interested to know how you get on either way. |
|
|
Hi, I tried it out with rev7832 and the patch. As I've said in the irc channel, it works for the given example! I can't guarantee that this completely solves my original problem, but so far it works and I have a good feeling about this :) You can close this report, in the worst case I would reopen it. Thanks! Best Benjamin |
|
|
committed to svn for 2.X carl - looks as if this is not needed for 3.x |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-09-20 14:27 | realhangman | New Issue | |
| 2010-09-20 21:15 | cth103 | cost | => 0.00 |
| 2010-09-20 21:15 | cth103 | Target Version | => 2.8.12 |
| 2010-09-22 14:36 | realhangman | Note Added: 0009137 | |
| 2010-09-22 15:45 | cth103 | File Added: 3466.patch | |
| 2010-09-22 15:46 | cth103 | Note Added: 0009138 | |
| 2010-09-22 15:47 | cth103 | Status | new => feedback |
| 2010-09-22 18:15 | realhangman | Note Added: 0009139 | |
| 2010-09-22 20:36 | cth103 | Status | feedback => assigned |
| 2010-09-22 20:36 | cth103 | Assigned To | => paul |
| 2010-09-24 12:19 | paul | Note Added: 0009154 | |
| 2010-09-24 12:19 | paul | Status | assigned => resolved |
| 2010-09-24 12:19 | paul | Resolution | open => fixed |
| 2020-04-19 20:14 | system | Note Added: 0022230 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
