View Issue Details

IDProjectCategoryView StatusLast Update
0003462ardourbugspublic2020-04-19 20:14
ReporterKarsten Wiese Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0003462: [PATCH] use ::get_icon () to load ardour_icon_48px in ArdourStartup::ctor
Descriptionsimplifies env needed to start from build directory.
TagsNo tags attached.

Activities

2010-09-19 16:53

 

use-get_icon-in-ArdourStartup_ctor.diff (1,017 bytes)   
Index: gtk2_ardour/startup.cc
===================================================================
--- gtk2_ardour/startup.cc	(revision 7797)
+++ gtk2_ardour/startup.cc	(working copy)
@@ -39,6 +39,7 @@
 #include "opts.h"
 #include "engine_dialog.h"
 #include "i18n.h"
+#include "utils.h"
 
 using namespace std;
 using namespace Gtk;
@@ -93,20 +94,10 @@
 	set_position (WIN_POS_CENTER);
 	set_border_width (12);
 
-	sys::path icon_file;
-
-	if (!find_file_in_search_path (ardour_search_path() + system_data_search_path().add_subdirectory_to_paths("icons"), "ardour_icon_48px.png", icon_file)) {
+	if ((icon_pixbuf = ::get_icon ("ardour_icon_48px")) == 0) {
 		throw failed_constructor();
 	}
 
-	try {
-		icon_pixbuf = Gdk::Pixbuf::create_from_file (icon_file.to_string());
-	}
-
-	catch (...) {
-		throw failed_constructor();
-	}
-
 	sys::path been_here_before = user_config_directory();
 	been_here_before /= ".a3"; // XXXX use more specific version so we can catch upgrades
 	new_user = !exists (been_here_before);

cth103

2010-09-19 17:10

administrator   ~0009101

Applied to SVN. Thanks!

system

2020-04-19 20:14

developer   ~0022229

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2010-09-19 16:53 Karsten Wiese New Issue
2010-09-19 16:53 Karsten Wiese File Added: use-get_icon-in-ArdourStartup_ctor.diff
2010-09-19 17:10 cth103 cost => 0.00
2010-09-19 17:10 cth103 Note Added: 0009101
2010-09-19 17:10 cth103 Status new => resolved
2010-09-19 17:10 cth103 Resolution open => fixed
2010-09-19 17:10 cth103 Assigned To => cth103
2020-04-19 20:14 system Note Added: 0022229
2020-04-19 20:14 system Status resolved => closed