View Issue Details

IDProjectCategoryView StatusLast Update
0003444ardourbugspublic2020-04-19 20:14
Reporterlincoln Assigned Tocth103  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Target Version3.0-beta1 
Summary0003444: [PATCH] Plugins not place correctly when loading A2 sessions in A3
DescriptionThe pre/post fader position of plugins is not presently being correctly when loading an A2 session in A3. All plugins are place pre-fader. The attached patch fixes this issue.
TagsNo tags attached.

Activities

2010-09-08 11:44

 

2x-insert-placement-fix.patch (674 bytes)   
Index: libs/ardour/route.cc
===================================================================
--- libs/ardour/route.cc	(revision 7755)
+++ libs/ardour/route.cc	(working copy)
@@ -931,6 +931,7 @@
 
 		XMLNodeList const & children = node.children ();
 		XMLNodeList::const_iterator i = children.begin ();
+		
 		while (i != children.end() && (*i)->name() != X_("Redirect")) {
 			++i;
 		}
@@ -938,7 +939,7 @@
 		Placement placement = PreFader;
 
 		if (i != children.end()) {
-			if ((prop = node.property (X_("placement"))) != 0) {
+			if ((prop = (*i)->property (X_("placement"))) != 0) {
 				placement = Placement (string_2_enum (prop->value(), placement));
 			}
 		}

cth103

2010-09-09 14:41

administrator   ~0009019

Applied. Thanks!

system

2020-04-19 20:14

developer   ~0022220

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2010-09-08 11:44 lincoln New Issue
2010-09-08 11:44 lincoln File Added: 2x-insert-placement-fix.patch
2010-09-08 15:35 cth103 cost => 0.00
2010-09-08 15:35 cth103 Target Version => 3.0-beta1
2010-09-08 15:35 cth103 Summary Plugins not place correctly when loading A2 sessions in A3 => [PATCH] Plugins not place correctly when loading A2 sessions in A3
2010-09-09 14:41 cth103 Note Added: 0009019
2010-09-09 14:41 cth103 Status new => resolved
2010-09-09 14:41 cth103 Resolution open => fixed
2010-09-09 14:41 cth103 Assigned To => cth103
2020-04-19 20:14 system Note Added: 0022220
2020-04-19 20:14 system Status resolved => closed