View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003441ardourbugspublic2010-09-05 20:392020-04-19 20:14
Reporterlincoln Assigned Topaul  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Target Version3.0-beta1 
Summary0003441: Loss of audio data on disk for A2 session opened and re-opened in A3
DescriptionPossible loss of data can occur in a Ardour 2 session opened in Ardour 3, saved and then re-opened. I am seeing this on a session that had a bunch of consolidated regions with created with the range tool. The wav files all had -bounce in their file name. When reopening the session in A3 for a second time these files are deleted from the file system.

1. open an A2 session in A3 (session contains consolidated regions)
files with -bounce in their name are present in the interchange folder and appear in the session, audio is present when played

2. save session so that it acquires A3 session format

3. go to Session->Recent and reopen the session

the files with -bounce in the name are gone
TagsNo tags attached.

Relationships

related to 0003453 new 2.X marks bounced files as removable 

Activities

lincoln

2010-09-05 21:39

reporter   ~0008996

The session file generated in ardour 2 is marking the bounce file as Removable for some reason. Ardour 3 will proceed to remove the file upon session close.

Consolidated file sources in Ardour 3 are created as RemovableIfEmpty and not removed on session close as expected.

<?xml version="1.0" encoding="UTF-8"?>
<Session version="2.0.0" name="testFileBug1" sample-rate="44100" id-counter="146">
  <Config>
    <Option name="output-auto-connect" value="2"/>
    <Option name="input-auto-connect" value="1"/>
    <Option name="meter-falloff" value="32"/>
    <end-marker-is-free val="no"/>
  </Config>
  <Sources>
    <Source name="Audio 1-1.wav" id="75" captured-for="Audio 1" flags="" channel="0"/>
    <Source name="Audio 1.1-0-bounce-1.wav" id="124" flags="Writable,CanRename,Removable,RemovableIfEmpty" channel="0"/>
  </Sources>

lincoln

2010-09-06 01:18

reporter   ~0008997

Attached patch makes all incoming sources immutable and fixes this issue. Still need to find why flags are still set on save in A2.

2010-09-06 17:48

 

x2-consolidated-sources-clobber-fix.patch (558 bytes)    
Index: libs/ardour/source.cc
===================================================================
--- libs/ardour/source.cc	(revision 7743)
+++ libs/ardour/source.cc	(working copy)
@@ -140,12 +140,16 @@
 		_flags = Flag (0);
 
 	}
-
+	
 	/* old style, from the period when we had DestructiveFileSource */
 	if ((prop = node.property (X_("destructive"))) != 0) {
 		_flags = Flag (_flags | Destructive);
 	}
 
+	if (!(_flags & Destructive)) {
+		_flags = Flag (_flags & ~(Writable|Removable|RemovableIfEmpty|RemoveAtDestroy|CanRename));
+	}
+
 	return 0;
 }
x2-consolidated-sources-clobber-fix.patch (558 bytes)   

paul

2010-09-15 15:22

administrator   ~0009061

patch applied (rev 7781), and new (related) bug for 2.x has been filed.

system

2020-04-19 20:14

developer   ~0022217

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2010-09-05 20:39 lincoln New Issue
2010-09-05 21:39 lincoln Note Added: 0008996
2010-09-06 01:18 lincoln Note Added: 0008997
2010-09-06 07:44 cth103 cost => 0.00
2010-09-06 07:44 cth103 Target Version => 3.0-beta1
2010-09-06 17:48 lincoln File Added: x2-consolidated-sources-clobber-fix.patch
2010-09-15 15:21 paul Relationship added related to 0003453
2010-09-15 15:22 paul Note Added: 0009061
2010-09-15 15:22 paul Status new => resolved
2010-09-15 15:22 paul Resolution open => fixed
2010-09-15 15:22 paul Assigned To => paul
2020-04-19 20:14 system Note Added: 0022217
2020-04-19 20:14 system Status resolved => closed