View Issue Details

IDProjectCategoryView StatusLast Update
0003401ardourotherpublic2020-04-19 20:14
Reporterlincoln Assigned Tocth103  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Summary0003401: Tweak ordering of zoom buttons
DescriptionThe ordering of the editor track height are the inverse of the time zoom buttons. The current layout is [-][+][1:1][+][-][Position] (time, height, position).

The attached patch changes the height button order to [-][+] to be consistent with the time zoom ordering. Also the zoom focus position is moved next to the time zoom buttons since it only affect these functions.

The new order is [-][+][1:1][Position][-][+] (time, position, height).
TagsNo tags attached.

Activities

2010-08-16 07:18

 

zoom-buttons-position-tweak.patch (944 bytes)   
Index: gtk2_ardour/editor.cc
===================================================================
--- gtk2_ardour/editor.cc	(revision 7634)
+++ gtk2_ardour/editor.cc	(working copy)
@@ -3055,6 +3055,8 @@
 	_zoom_box.pack_start (zoom_in_button, false, false);
 	_zoom_box.pack_start (zoom_out_full_button, false, false);
 
+	_zoom_box.pack_start (zoom_focus_selector);
+	
 	/* Track zoom buttons */
 	tav_expand_button.set_name ("TrackHeightButton");
 	tav_expand_button.set_size_request(-1,20);
@@ -3066,10 +3068,8 @@
 	tav_shrink_button.add (*(manage (new Image (::get_icon("tav_shrink")))));
 	tav_shrink_button.signal_clicked().connect (sigc::bind (sigc::mem_fun(*this, &Editor::tav_zoom_step), false));
 
+	_zoom_box.pack_start (tav_shrink_button);
 	_zoom_box.pack_start (tav_expand_button);
-	_zoom_box.pack_start (tav_shrink_button);
-
-	_zoom_box.pack_start (zoom_focus_selector);
 	
 	_zoom_tearoff = manage (new TearOff (_zoom_box));
 

cth103

2010-08-17 13:51

administrator   ~0008851

Applied to SVN. Thanks!

system

2020-04-19 20:14

developer   ~0022199

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2010-08-16 07:18 lincoln New Issue
2010-08-16 07:18 lincoln File Added: zoom-buttons-position-tweak.patch
2010-08-17 13:51 cth103 cost => 0.00
2010-08-17 13:51 cth103 Note Added: 0008851
2010-08-17 13:51 cth103 Status new => resolved
2010-08-17 13:51 cth103 Resolution open => fixed
2010-08-17 13:51 cth103 Assigned To => cth103
2020-04-19 20:14 system Note Added: 0022199
2020-04-19 20:14 system Status resolved => closed