View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003369 | ardour | bugs | public | 2010-07-27 22:41 | 2020-04-19 20:14 |
| Reporter | moshisushi | Assigned To | cth103 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta1 | ||||
| Summary | 0003369: Playback gets stuck in loop mode | ||||
| Description | Steps to reproduce the bug: 1. Select a region 2. Hit Alt+] to set loop markers for that region 3. Press L or the "looped playback" button 4. Stop playback 5. Start normal playback from the beginning of the region Expected behaviour: Playback should continue when the region ends, without looping. Actual behaviour: The playhead moves as if looping is no longer active, but the region's audio is still being looped. | ||||
| Tags | No tags attached. | ||||
|
|
Perhaps an interesting observation: looping in A3 sounds a little dodgy right now, with (often very) small glitches when the loop starts over from the beginning. However, when the buggy looping (as described above) occurs, those glitches are gone. |
|
|
I can no longer reproduce this. Can you? |
|
|
Lincoln reports that this still happens. |
|
2011-01-08 20:46
|
sticky-loop-play-fix.patch (1,895 bytes)
Index: gtk2_ardour/ardour_ui.cc
===================================================================
--- gtk2_ardour/ardour_ui.cc (revision 8483)
+++ gtk2_ardour/ardour_ui.cc (working copy)
@@ -1687,22 +1687,31 @@
void
ARDOUR_UI::toggle_session_auto_loop ()
{
- if (_session) {
- if (_session->get_play_loop()) {
- if (_session->transport_rolling()) {
- Location * looploc = _session->locations()->auto_loop_location();
- if (looploc) {
- _session->request_locate (looploc->start(), true);
- }
- } else {
+ if (!_session) {
+ return;
+ }
+
+ if (_session->get_play_loop()) {
+
+ if (_session->transport_rolling()) {
+
+ Location * looploc = _session->locations()->auto_loop_location();
+
+ if (looploc) {
+ _session->request_locate (looploc->start(), true);
_session->request_play_loop (false);
}
+
} else {
- Location * looploc = _session->locations()->auto_loop_location();
- if (looploc) {
- _session->request_play_loop (true);
- }
+ _session->request_play_loop (false);
}
+ } else {
+
+ Location * looploc = _session->locations()->auto_loop_location();
+
+ if (looploc) {
+ _session->request_play_loop (true);
+ }
}
}
Index: libs/ardour/session_transport.cc
===================================================================
--- libs/ardour/session_transport.cc (revision 8483)
+++ libs/ardour/session_transport.cc (working copy)
@@ -944,6 +944,7 @@
if (Config->get_monitoring_model() == HardwareMonitoring)
{
boost::shared_ptr<RouteList> rl = routes.reader();
+
for (RouteList::iterator i = rl->begin(); i != rl->end(); ++i) {
boost::shared_ptr<Track> tr = boost::dynamic_pointer_cast<Track> (*i);
if (tr && tr->record_enabled ()) {
@@ -965,6 +966,8 @@
} else {
stop_transport (abort);
}
+
+ unset_play_loop ();
} else if (transport_stopped() && speed == 1.0) {
|
|
|
Attached patch clears this for me here. |
|
|
Patch has been applied by Paul. If there are no reported issues with it, I guess we can close this one. |
|
|
See notes. Please re-open if you still have problems. Thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-07-27 22:41 | moshisushi | New Issue | |
| 2010-07-27 23:04 | moshisushi | Note Added: 0008676 | |
| 2010-07-28 01:41 | cth103 | cost | => 0.00 |
| 2010-07-28 01:41 | cth103 | Target Version | => 3.0-beta1 |
| 2010-07-29 22:12 | cth103 | Status | new => confirmed |
| 2010-12-08 01:55 | cth103 | Relationship added | has duplicate 0003545 |
| 2010-12-12 16:50 | cth103 | Note Added: 0009601 | |
| 2010-12-12 16:50 | cth103 | Status | confirmed => feedback |
| 2011-01-08 19:52 | cth103 | Note Added: 0009884 | |
| 2011-01-08 19:52 | cth103 | Relationship added | has duplicate 0003697 |
| 2011-01-08 20:46 | lincoln | File Added: sticky-loop-play-fix.patch | |
| 2011-01-08 20:47 | lincoln | Note Added: 0009885 | |
| 2011-01-10 12:26 | lincoln | Note Added: 0009903 | |
| 2011-01-10 14:18 | cth103 | Note Added: 0009904 | |
| 2011-01-10 14:18 | cth103 | Status | feedback => resolved |
| 2011-01-10 14:18 | cth103 | Resolution | open => fixed |
| 2011-01-10 14:18 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:14 | system | Note Added: 0022185 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
