View Issue Details

IDProjectCategoryView StatusLast Update
0003304ardourbugspublic2020-04-19 20:14
Reporterlincoln Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0003304: Editor Group status not honoured
DescriptionEdit operations on regions on tracks that belong to a group are not taking into account the group's activity status. If a group is de-activated operations still apply to the group.

The attached patch takes care of this.
TagsNo tags attached.

Activities

2010-07-06 09:02

 

editor-selection-group-activity.patch (1,063 bytes)   
Index: gtk2_ardour/editor_selection.cc
===================================================================
--- gtk2_ardour/editor_selection.cc	(revision 7380)
+++ gtk2_ardour/editor_selection.cc	(working copy)
@@ -294,6 +294,7 @@
 Editor::mapover_tracks (sigc::slot<void, RouteTimeAxisView&, uint32_t> sl, TimeAxisView* basis, PBD::PropertyID prop) const
 {
 	RouteTimeAxisView* route_basis = dynamic_cast<RouteTimeAxisView*> (basis);
+
 	if (route_basis == 0) {
 		return;
 	}
@@ -302,8 +303,9 @@
 	tracks.insert (route_basis);
 
 	RouteGroup* group = route_basis->route()->route_group();
-	if (group && group->enabled_property (prop)) {
 
+	if (group && group->enabled_property(prop) && group->enabled_property (Properties::active.property_id) ) {
+
 		/* the basis is a member of an active route group, with the appropriate
 		   properties; find other members */
 
@@ -317,6 +319,7 @@
 
 	/* call the slots */
 	uint32_t const sz = tracks.size ();
+	
 	for (set<RouteTimeAxisView*>::iterator i = tracks.begin(); i != tracks.end(); ++i) {
 		sl (**i, sz);
 	}

paul

2010-07-06 11:34

administrator   ~0008400

committed, thanks.

system

2020-04-19 20:14

developer   ~0022153

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2010-07-06 09:02 lincoln New Issue
2010-07-06 09:02 lincoln File Added: editor-selection-group-activity.patch
2010-07-06 11:34 paul cost => 0.00
2010-07-06 11:34 paul Note Added: 0008400
2010-07-06 11:34 paul Status new => resolved
2010-07-06 11:34 paul Resolution open => fixed
2010-07-06 11:34 paul Assigned To => paul
2020-04-19 20:14 system Note Added: 0022153
2020-04-19 20:14 system Status resolved => closed