View Issue Details

IDProjectCategoryView StatusLast Update
0003299ardourbugspublic2020-04-19 20:14
Reporterlincoln Assigned Tocth103  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Target Version3.0-beta1 
Summary0003299: x-axis editor scrolling in editor summary limited to view box height
DescriptionThe summary view will only allow you to scroll the editor horizontally if the mouse is placed vertically in line with the summary box. As a result scrolling becomes difficult when there are many tracks in a session and the box becomes small. The attached patch fixes this issue.
TagsNo tags attached.

Activities

2010-07-03 10:27

 

editor-summary-h-scroll-fix.patch (2,318 bytes)   
Index: gtk2_ardour/editor_summary.cc
===================================================================
--- gtk2_ardour/editor_summary.cc	(revision 7363)
+++ gtk2_ardour/editor_summary.cc	(working copy)
@@ -309,7 +309,17 @@
 		_start_mouse_y = ev->y;
 		_start_position = get_position (ev->x, ev->y);
 
-		if (_start_position != INSIDE && _start_position != BELOW_OR_ABOVE &&
+		if (Keyboard::modifier_state_equals (ev->state, Keyboard::SecondaryModifier)) {
+			/* secondary-modifier-click: locate playhead */
+			if (_session) {
+				_session->request_locate (ev->x / _x_scale + _start);
+			}
+
+		} else if (Keyboard::modifier_state_equals (ev->state, Keyboard::TertiaryModifier)) {
+
+			centre_on_click (ev);
+			
+		} else if (_start_position != INSIDE && _start_position != BELOW_OR_ABOVE &&
 		    _start_position != TO_LEFT_OR_RIGHT && _start_position != OTHERWISE_OUTSIDE
 			) {
 
@@ -319,17 +329,6 @@
 			_zoom_dragging = true;
 			_editor->_dragging_playhead = true;
 
-		} else if (Keyboard::modifier_state_equals (ev->state, Keyboard::SecondaryModifier)) {
-
-			/* secondary-modifier-click: locate playhead */
-			if (_session) {
-				_session->request_locate (ev->x / _x_scale + _start);
-			}
-
-		} else if (Keyboard::modifier_state_equals (ev->state, Keyboard::TertiaryModifier)) {
-
-			centre_on_click (ev);
-
 		} else {
 
 			/* start a move drag */
@@ -371,7 +370,8 @@
  	bool const near_bottom = (std::abs (y - _view_rectangle_y.second) < edge_size);
 	bool const within_x = _view_rectangle_x.first < x && x < _view_rectangle_x.second;
 	bool const within_y = _view_rectangle_y.first < y && y < _view_rectangle_y.second;
-
+	bool const to_left_or_right = _view_rectangle_x.first > x || _view_rectangle_x.second < x;
+	
 	if (near_left && near_top) {
 		return LEFT_TOP;
 	} else if (near_left && near_bottom) {
@@ -392,6 +392,8 @@
 		return INSIDE;
 	} else if (within_x) {
 		return BELOW_OR_ABOVE;
+	} else if (to_left_or_right) {
+		return TO_LEFT_OR_RIGHT;
 	} else if (within_y) {
 		return TO_LEFT_OR_RIGHT;
 	} else {
@@ -449,6 +451,7 @@
 
 		/* don't alter x if we clicked outside and above or below the viewbox */
 		if (_start_position == INSIDE || _start_position == TO_LEFT_OR_RIGHT) {
+		  
 			xr.first += ev->x - _start_mouse_x;
 			xr.second += ev->x - _start_mouse_x;
 		}

cth103

2010-07-04 21:53

administrator   ~0008385

Thanks for the patch. I've applied a modified version to SVN 7364; did I preserve what you meant ok?

lincoln

2010-07-04 22:45

reporter   ~0008386

Yeah, that does it.

cth103

2010-07-04 22:51

administrator   ~0008387

Thanks!

system

2020-04-19 20:14

developer   ~0022150

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2010-07-03 10:27 lincoln New Issue
2010-07-03 10:27 lincoln File Added: editor-summary-h-scroll-fix.patch
2010-07-04 11:35 cth103 cost => 0.00
2010-07-04 11:35 cth103 Target Version => 3.0-beta1
2010-07-04 21:53 cth103 Note Added: 0008385
2010-07-04 21:53 cth103 Status new => feedback
2010-07-04 22:45 lincoln Note Added: 0008386
2010-07-04 22:51 cth103 Note Added: 0008387
2010-07-04 22:51 cth103 Status feedback => resolved
2010-07-04 22:51 cth103 Resolution open => fixed
2010-07-04 22:51 cth103 Assigned To => cth103
2020-04-19 20:14 system Note Added: 0022150
2020-04-19 20:14 system Status resolved => closed