View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003223 | ardour | features | public | 2010-06-05 09:50 | 2020-04-19 20:14 |
| Reporter | lincoln | Assigned To | cth103 | ||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta1 | ||||
| Summary | 0003223: [PATCH] Add ability to Show/Hide Midi tracks in Route List | ||||
| Description | Ardour 3 does not allow you to show or hide tracks from the route list on the right. The attached patch adds this capability. | ||||
| Tags | No tags attached. | ||||
|
2010-06-05 09:50
|
editor-routes-midi-hide-show.patch (3,393 bytes)
Index: gtk2_ardour/editor_routes.cc
===================================================================
--- gtk2_ardour/editor_routes.cc (revision 7233)
+++ gtk2_ardour/editor_routes.cc (working copy)
@@ -303,6 +303,8 @@
items.push_back (MenuElem (_("Hide All Audio Tracks"), sigc::mem_fun (*this, &EditorRoutes::hide_all_audiotracks)));
items.push_back (MenuElem (_("Show All Audio Busses"), sigc::mem_fun (*this, &EditorRoutes::show_all_audiobus)));
items.push_back (MenuElem (_("Hide All Audio Busses"), sigc::mem_fun (*this, &EditorRoutes::hide_all_audiobus)));
+ items.push_back (MenuElem (_("Show All Midi Tracks"), sigc::mem_fun (*this, &EditorRoutes::show_all_miditracks)));
+ items.push_back (MenuElem (_("Hide All Midi Tracks"), sigc::mem_fun (*this, &EditorRoutes::hide_all_miditracks)));
items.push_back (MenuElem (_("Show Tracks With Regions Under Playhead"), sigc::mem_fun (*this, &EditorRoutes::show_tracks_with_regions_at_playhead)));
}
@@ -694,7 +696,7 @@
}
void
-EditorRoutes::set_all_audio_visibility (int tracks, bool yn)
+EditorRoutes::set_all_audio_midi_visibility (int tracks, bool yn)
{
TreeModel::Children rows = _model->children();
TreeModel::Children::iterator i;
@@ -702,10 +704,13 @@
suspend_redisplay ();
for (i = rows.begin(); i != rows.end(); ++i) {
+
TreeModel::Row row = (*i);
TimeAxisView* tv = row[_columns.tv];
+
AudioTimeAxisView* atv;
-
+ MidiTimeAxisView* mtv;
+
if (tv == 0) {
continue;
}
@@ -729,6 +734,19 @@
break;
}
}
+ else if ((mtv = dynamic_cast<MidiTimeAxisView*>(tv)) != 0) {
+ switch (tracks) {
+ case 0:
+ (*i)[_columns.visible] = yn;
+ break;
+
+ case 3:
+ if (mtv->is_midi_track()) {
+ (*i)[_columns.visible] = yn;
+ }
+ break;
+ }
+ }
}
resume_redisplay ();
@@ -747,25 +765,36 @@
}
void
+EditorRoutes::show_all_audiotracks()
+{
+ set_all_audio_midi_visibility (1, true);
+}
+void
+EditorRoutes::hide_all_audiotracks ()
+{
+ set_all_audio_midi_visibility (1, false);
+}
+
+void
EditorRoutes::show_all_audiobus ()
{
- set_all_audio_visibility (2, true);
+ set_all_audio_midi_visibility (2, true);
}
void
EditorRoutes::hide_all_audiobus ()
{
- set_all_audio_visibility (2, false);
+ set_all_audio_midi_visibility (2, false);
}
void
-EditorRoutes::show_all_audiotracks()
+EditorRoutes::show_all_miditracks()
{
- set_all_audio_visibility (1, true);
+ set_all_audio_midi_visibility (3, true);
}
void
-EditorRoutes::hide_all_audiotracks ()
+EditorRoutes::hide_all_miditracks ()
{
- set_all_audio_visibility (1, false);
+ set_all_audio_midi_visibility (3, false);
}
bool
Index: gtk2_ardour/editor_routes.h
===================================================================
--- gtk2_ardour/editor_routes.h (revision 7233)
+++ gtk2_ardour/editor_routes.h (working copy)
@@ -78,13 +78,15 @@
void update_solo_isolate_display ();
void update_solo_safe_display ();
void set_all_tracks_visibility (bool);
- void set_all_audio_visibility (int, bool);
+ void set_all_audio_midi_visibility (int, bool);
void show_all_routes ();
void hide_all_routes ();
void show_all_audiotracks ();
void hide_all_audiotracks ();
void show_all_audiobus ();
void hide_all_audiobus ();
+ void show_all_miditracks ();
+ void hide_all_miditracks ();
void show_tracks_with_regions_at_playhead ();
void display_drag_data_received (
|
|
|
Applied to SVN. Thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-06-05 09:50 | lincoln | New Issue | |
| 2010-06-05 09:50 | lincoln | File Added: editor-routes-midi-hide-show.patch | |
| 2010-06-05 10:11 | cth103 | cost | => 0.00 |
| 2010-06-05 10:11 | cth103 | Status | new => acknowledged |
| 2010-06-05 10:11 | cth103 | Target Version | => 3.0-beta1 |
| 2010-06-05 10:11 | cth103 | Summary | Add ability to Show/Hide Midi tracks in Route List => [PATCH] Add ability to Show/Hide Midi tracks in Route List |
| 2010-06-06 00:57 | cth103 | Note Added: 0008170 | |
| 2010-06-06 00:57 | cth103 | Status | acknowledged => resolved |
| 2010-06-06 00:57 | cth103 | Resolution | open => fixed |
| 2010-06-06 00:57 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:14 | system | Note Added: 0022118 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
