View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003199 | ardour | features | public | 2010-05-27 10:23 | 2020-04-19 20:14 |
| Reporter | lincoln | Assigned To | paul | ||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta1 | ||||
| Summary | 0003199: [PATCH] Note grid outlines should be disabled when the track height goes under a certain value | ||||
| Description | Midi note guide lines in the midi region view are never turned off when the height of the view is so small that no practical editing can be done. This makes the editor screen look rather messy when a number of midi tracks exist. Note guide lines should not be renderd below a certain height. | ||||
| Tags | No tags attached. | ||||
|
2010-05-29 00:37
|
midi-note-lines.patch (429 bytes)
Index: gtk2_ardour/midi_streamview.cc
===================================================================
--- gtk2_ardour/midi_streamview.cc (revision 7192)
+++ gtk2_ardour/midi_streamview.cc (working copy)
@@ -296,7 +296,13 @@
{
StreamView::update_contents_height();
_note_lines->property_y2() = height;
- draw_note_lines();
+
+ if(height < 140){
+ _note_lines->clear();
+ }
+ else {
+ draw_note_lines();
+ }
}
void
|
|
|
Patch for this included here. Lines appear with scroomer. |
|
2010-05-29 11:28
|
midi-note-lines-2.patch (700 bytes)
Index: gtk2_ardour/midi_streamview.cc
===================================================================
--- gtk2_ardour/midi_streamview.cc (revision 7192)
+++ gtk2_ardour/midi_streamview.cc (working copy)
@@ -212,7 +212,9 @@
MidiStreamView::display_track (boost::shared_ptr<Track> tr)
{
StreamView::display_track (tr);
+
draw_note_lines();
+
NoteRangeChanged();
}
@@ -296,6 +298,7 @@
{
StreamView::update_contents_height();
_note_lines->property_y2() = height;
+
draw_note_lines();
}
@@ -307,6 +310,10 @@
uint32_t color;
_note_lines->clear();
+
+ if(height < 140){
+ return;
+ }
for (int i = lowest_note(); i <= highest_note(); ++i) {
y = floor(note_to_y(i));
|
|
|
Better patch for this. |
|
|
nice. committed rev 7194. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-05-27 10:23 | lincoln | New Issue | |
| 2010-05-29 00:37 | lincoln | File Added: midi-note-lines.patch | |
| 2010-05-29 00:38 | lincoln | Note Added: 0008092 | |
| 2010-05-29 11:07 | cth103 | cost | => 0.00 |
| 2010-05-29 11:07 | cth103 | Status | new => acknowledged |
| 2010-05-29 11:07 | cth103 | Target Version | => 3.0-beta1 |
| 2010-05-29 11:07 | cth103 | Summary | Note grid outlines should be disabled when the track height goes under a certain value => [PATCH] Note grid outlines should be disabled when the track height goes under a certain value |
| 2010-05-29 11:28 | lincoln | File Added: midi-note-lines-2.patch | |
| 2010-05-29 11:29 | lincoln | Note Added: 0008093 | |
| 2010-05-29 12:16 | paul | Note Added: 0008094 | |
| 2010-05-29 12:16 | paul | Status | acknowledged => resolved |
| 2010-05-29 12:16 | paul | Resolution | open => fixed |
| 2010-05-29 12:16 | paul | Assigned To | => paul |
| 2020-04-19 20:14 | system | Note Added: 0022103 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
