View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003107 | ardour | bugs | public | 2010-05-04 17:36 | 2020-04-19 20:14 |
| Reporter | d13b | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Target Version | 2.8.8 | ||||
| Summary | 0003107: fix for bug #0002997 causes crash when importing soundfiles | ||||
| Description | using ardourvst from svn 2.0-ongoing rev 7051, ardour crashes when i try to import a soundfile: "wine: Unhandled page fault on read access to 0x00000052 at address 0x7d210f9a " ... Backtrace: =>0 0x7d210f9a (0x0033eb88) 1 0x7d65dc33 _ZN4Glib7ustringC1ERKS0_+0x23() in libglibmm2.so (0x6ef30678) this seems to be related to the fix for bug 0002997 removing " -D_FILE_OFFSET_BITS=64" from libs/ardour/SConscript line 133 fixes the import-problem. | ||||
| Additional Information | my system is debian unstable ardour is compiled with scons -j2LIBLO=1 AUBIO=1 FREESOUND=1 SURFACES=1 FPU_OPTIMIZATION=1 AUBIO=1 WIIMOTE=1 FFT_ANALYSIS=1 TRANZPORT=1 SLV2=1 VST=1 software versions: wine-1.1.32 gcc version 4.4.4 jackd 1.9.5~dfsg-6 libasound2 1.0.22-2 | ||||
| Tags | No tags attached. | ||||
|
|
It's a slightly long shot, but can you just try rebuilding ardour from scratch to see if that fixes it? (scons -c) |
|
|
i did a complete build after scons -c and got the same result: crash when i try to import any soundfile, no crash when i recompiled without -D_FILE_OFFSET_BITS=64 |
|
|
Thanks for checking. Will investigate. |
|
2010-05-06 00:11
|
3107.patch (6,991 bytes)
diff --git a/gtk2_ardour/SConscript b/gtk2_ardour/SConscript
index 2ebbe8b..765cc09 100644
--- a/gtk2_ardour/SConscript
+++ b/gtk2_ardour/SConscript
@@ -315,7 +315,7 @@ if env['FREESOUND']:
intl_files += extra_sources
-gtkardour.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+gtkardour.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
gtkardour.Append(CXXFLAGS="-DLOCALEDIR=\\\""+final_prefix+"/share/locale\\\"")
versionflag = '-DVERSIONSTRING=\\\"' + env['VERSION'] + '\\\"'
diff --git a/libs/midi++2/SConscript b/libs/midi++2/SConscript
index 21356da..29ba204 100644
--- a/libs/midi++2/SConscript
+++ b/libs/midi++2/SConscript
@@ -43,7 +43,7 @@ else:
sysdep_src = [ 'alsa_sequencer_midiport.cc' ]
midi2.Append (CCFLAGS="-DWITH_ALSA")
-midi2.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+midi2.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
midi2.Append(CCFLAGS="-DLIBSIGC_DISABLE_DEPRECATED")
midi2.VersionBuild(['version.cc','midi++/version.h'], [])
diff --git a/libs/pbd/SConscript b/libs/pbd/SConscript
index b33ab58..04965d0 100644
--- a/libs/pbd/SConscript
+++ b/libs/pbd/SConscript
@@ -12,7 +12,7 @@ domain = 'libpbd'
pbd.Append(DOMAIN=domain,MAJOR=4,MINOR=1,MICRO=0)
pbd.Append(CXXFLAGS="-DPACKAGE=\\\"" + domain + "\\\"")
-pbd.Append(CXXFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+pbd.Append(CXXFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
pbd.Append(CXXFLAGS="-DLIBSIGC_DISABLE_DEPRECATED")
pbd.Append(PACKAGE=domain)
pbd.Append(POTFILE=domain + '.pot')
diff --git a/libs/soundtouch/SConscript b/libs/soundtouch/SConscript
index 71f1d9b..50ced25 100644
--- a/libs/soundtouch/SConscript
+++ b/libs/soundtouch/SConscript
@@ -17,7 +17,7 @@ cpu_detect_x86_gcc.cpp
Import('env install_prefix')
st = env.Clone()
-st.Append(CCFLAGS="-DHAVE_CONFIG_H -D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+st.Append(CCFLAGS="-DHAVE_CONFIG_H -D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
libst = st.SharedLibrary('soundtouch', soundtouch_files)
diff --git a/libs/surfaces/control_protocol/SConscript b/libs/surfaces/control_protocol/SConscript
index 4ae3406..c57ee5b 100644
--- a/libs/surfaces/control_protocol/SConscript
+++ b/libs/surfaces/control_protocol/SConscript
@@ -26,7 +26,7 @@ control_protocol.cc
smpte.cc
""")
-cp.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+cp.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
cp.Append(CXXFLAGS="-DDATA_DIR=\\\""+final_prefix+"/share\\\"")
cp.Append(CXXFLAGS="-DCONFIG_DIR=\\\""+final_config_prefix+"\\\"")
cp.Append(CXXFLAGS="-DLOCALEDIR=\\\""+final_prefix+"/share/locale\\\"")
diff --git a/libs/surfaces/frontier/tranzport/SConscript b/libs/surfaces/frontier/tranzport/SConscript
index 582f4a7..1b45bf2 100644
--- a/libs/surfaces/frontier/tranzport/SConscript
+++ b/libs/surfaces/frontier/tranzport/SConscript
@@ -25,7 +25,7 @@ interface.cc
tranzport_control_protocol.cc
""")
-tranzport.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+tranzport.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
tranzport.Append(CXXFLAGS="-DDATA_DIR=\\\""+final_prefix+"/share\\\"")
tranzport.Append(CXXFLAGS="-DCONFIG_DIR=\\\""+final_config_prefix+"\\\"")
tranzport.Append(CXXFLAGS="-DLOCALEDIR=\\\""+final_prefix+"/share/locale\\\"")
diff --git a/libs/surfaces/generic_midi/SConscript b/libs/surfaces/generic_midi/SConscript
index 27f8865..b509fdc 100644
--- a/libs/surfaces/generic_midi/SConscript
+++ b/libs/surfaces/generic_midi/SConscript
@@ -26,7 +26,7 @@ generic_midi_control_protocol.cc
midicontrollable.cc
""")
-genericmidi.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+genericmidi.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
genericmidi.Append(CXXFLAGS="-DDATA_DIR=\\\""+final_prefix+"/share\\\"")
genericmidi.Append(CXXFLAGS="-DCONFIG_DIR=\\\""+final_config_prefix+"\\\"")
genericmidi.Append(CXXFLAGS="-DLOCALEDIR=\\\""+final_prefix+"/share/locale\\\"")
diff --git a/libs/surfaces/mackie/SConscript b/libs/surfaces/mackie/SConscript
index 6dcab46..46c283f 100644
--- a/libs/surfaces/mackie/SConscript
+++ b/libs/surfaces/mackie/SConscript
@@ -48,7 +48,7 @@ mackie_surface_generated.cc
mackie_jog_wheel.cc
""")
-mackie.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+mackie.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
mackie.Append(CXXFLAGS="-DDATA_DIR=\\\""+final_prefix+"/share\\\"")
mackie.Append(CXXFLAGS="-DCONFIG_DIR=\\\""+final_config_prefix+"\\\"")
mackie.Append(CXXFLAGS="-DLOCALEDIR=\\\""+final_prefix+"/share/locale\\\"")
diff --git a/libs/surfaces/powermate/SConscript b/libs/surfaces/powermate/SConscript
index 216ae4d..fb1d992 100644
--- a/libs/surfaces/powermate/SConscript
+++ b/libs/surfaces/powermate/SConscript
@@ -25,7 +25,7 @@ interface.cc
powermate.cc
""")
-powermate.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+powermate.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
powermate.Append(CXXFLAGS="-DDATA_DIR=\\\""+final_prefix+"/share\\\"")
powermate.Append(CXXFLAGS="-DCONFIG_DIR=\\\""+final_config_prefix+"\\\"")
powermate.Append(CXXFLAGS="-DLOCALEDIR=\\\""+final_prefix+"/share/locale\\\"")
diff --git a/libs/surfaces/tranzport/SConscript b/libs/surfaces/tranzport/SConscript
index c2ab351..9b207c4 100644
--- a/libs/surfaces/tranzport/SConscript
+++ b/libs/surfaces/tranzport/SConscript
@@ -44,7 +44,7 @@ wheel.cc
#io_midi.cc
#io_kernel.cc
-tranzport.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+tranzport.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
tranzport.Append(CXXFLAGS="-DDATA_DIR=\\\""+final_prefix+"/share\\\"")
tranzport.Append(CXXFLAGS="-DCONFIG_DIR=\\\""+final_config_prefix+"\\\"")
tranzport.Append(CXXFLAGS="-DLOCALEDIR=\\\""+final_prefix+"/share/locale\\\"")
diff --git a/libs/surfaces/wiimote/SConscript b/libs/surfaces/wiimote/SConscript
index c530445..ef3e34f 100644
--- a/libs/surfaces/wiimote/SConscript
+++ b/libs/surfaces/wiimote/SConscript
@@ -25,7 +25,7 @@ wiimote.cc
interface.cc
""")
-wiimote.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE")
+wiimote.Append(CCFLAGS="-D_REENTRANT -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64")
wiimote.Append(CXXFLAGS="-DDATA_DIR=\\\""+final_prefix+"/share\\\"")
wiimote.Append(CXXFLAGS="-DCONFIG_DIR=\\\""+final_config_prefix+"\\\"")
wiimote.Append(CXXFLAGS="-DLOCALEDIR=\\\""+final_prefix+"/share/locale\\\"")
|
|
|
I believe this is fixed by the attached patch. Could you perhaps check? |
|
|
yes, this patch solves the import-problem - no crash any more. |
|
|
Great, thanks. Paul, it seems that we have to set that flag everywhere rather than just in libardour. |
|
|
actually, i am having a hard time imagining how this can ever work. what about C libraries outside Ardour? i haven't looked in the headers to see what the define does, perhaps that might reveal how this works (or not). i'll fix the build to have the flag at the global level. |
|
|
this is fixed ("fixed") in 2.X and 3.0 svn, by moving several compiler flags up to the "top level" of the build system. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-05-04 17:36 | d13b | New Issue | |
| 2010-05-05 20:47 | cth103 | Note Added: 0007789 | |
| 2010-05-05 20:47 | cth103 | Status | new => feedback |
| 2010-05-05 22:31 | d13b | Note Added: 0007792 | |
| 2010-05-06 00:02 | cth103 | Status | feedback => confirmed |
| 2010-05-06 00:02 | cth103 | Note Added: 0007793 | |
| 2010-05-06 00:03 | cth103 | cost | => 0.00 |
| 2010-05-06 00:03 | cth103 | Target Version | => 2.8.8 |
| 2010-05-06 00:11 | cth103 | File Added: 3107.patch | |
| 2010-05-06 00:11 | cth103 | Note Added: 0007794 | |
| 2010-05-06 00:11 | cth103 | Status | confirmed => feedback |
| 2010-05-06 09:23 | d13b | Note Added: 0007798 | |
| 2010-05-06 10:03 | cth103 | Note Added: 0007799 | |
| 2010-05-06 10:03 | cth103 | Status | feedback => assigned |
| 2010-05-06 10:03 | cth103 | Assigned To | => paul |
| 2010-05-06 10:04 | cth103 | Note Edited: 0007799 | |
| 2010-05-06 12:21 | paul | Note Added: 0007818 | |
| 2010-05-07 16:55 | paul | Note Added: 0007822 | |
| 2010-05-07 16:55 | paul | Status | assigned => resolved |
| 2010-05-07 16:55 | paul | Resolution | open => fixed |
| 2020-04-19 20:14 | system | Note Added: 0022050 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
