View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002913 | ardour | bugs | public | 2009-11-15 12:35 | 2020-04-19 20:14 |
| Reporter | nowhiskey | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002913: [PATCH] adding plugins to pre-fader redirect becomes more slowly as more plugins are added | ||||
| Description | 2.8.4 as well as ongoing@6090 -create new session -right-click into the master channel pre-fader redirect -the menu appears ---> choose and add some plugin (add plugin -> by creator..) -right click again - add more plugins (one by one) -as more plugins are added, longer will ardour need to respond to the rightclick and to offer the pop-up menu. -when i close the session, and start again, adding the next plugin the pop-up menu will appear as fast as expected, but when continuing adding plugins, the appearance of the pop-up menu becomes more and more slowly. cheers, doc | ||||
| Tags | No tags attached. | ||||
|
2009-11-15 15:52
|
2913.patch (1,820 bytes)
diff --git a/gtk2_ardour/plugin_selector.cc b/gtk2_ardour/plugin_selector.cc
index 684ef2f..e5b8ae2 100644
--- a/gtk2_ardour/plugin_selector.cc
+++ b/gtk2_ardour/plugin_selector.cc
@@ -579,16 +579,16 @@ PluginSelector::plugin_menu()
items.clear ();
Gtk::Menu* favs = create_favs_menu(all_plugs);
- items.push_back (MenuElem (_("Favorites"), *favs));
+ items.push_back (MenuElem (_("Favorites"), *manage (favs)));
items.push_back (MenuElem (_("Plugin Manager"), mem_fun (*this, &PluginSelector::show_manager)));
items.push_back (SeparatorElem ());
Menu* by_creator = create_by_creator_menu(all_plugs);
- items.push_back (MenuElem (_("By Creator"), *by_creator));
+ items.push_back (MenuElem (_("By Creator"), *manage (by_creator)));
Menu* by_category = create_by_category_menu(all_plugs);
- items.push_back (MenuElem (_("By Category"), *by_category));
+ items.push_back (MenuElem (_("By Category"), *manage (by_category)));
return *_menu;
}
@@ -644,7 +644,7 @@ PluginSelector::create_by_creator_menu (ARDOUR::PluginInfoList& all_plugs)
submenu = x->second;
} else {
submenu = new Gtk::Menu;
- by_creator_items.push_back (MenuElem (creator, *submenu));
+ by_creator_items.push_back (MenuElem (creator, *manage (submenu)));
creator_submenu_map.insert (pair<Glib::ustring,Menu*> (creator, submenu));
submenu->set_name("ArdourContextMenu");
}
@@ -680,7 +680,7 @@ PluginSelector::create_by_category_menu (ARDOUR::PluginInfoList& all_plugs)
submenu = x->second;
} else {
submenu = new Gtk::Menu;
- by_category_items.push_back (MenuElem (category, *submenu));
+ by_category_items.push_back (MenuElem (category, *manage (submenu)));
category_submenu_map.insert (pair<Glib::ustring,Menu*> (category, submenu));
submenu->set_name("ArdourContextMenu");
}
|
|
|
You don't even have to choose a plugin, just repeatedly open and close the redirect box context menu. The attached patch improves things somewhat. I can't help thinking that this menu should only be created when the available plugins list changes. |
|
|
this patch indeed improves the things. don't know what else is running wrong here, but the patch looks like an improvement for me. cheers, doc |
|
|
patch applied to 2.X svn, along with other changes from rev 6091 (3.0) from carl. |
|
|
ok, this is working again -- thanks!! (although i have a feelng that it was working faster in the earlier versions). how ever, the process of the context menu appearing is not getting longer as more plugins we are adding anymore. cheers, doc |
|
|
this one feels resolved to me. any disagreement? |
|
|
agreed....resolved. cheers, doc |
|
|
Thanks. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-11-15 12:35 | nowhiskey | New Issue | |
| 2009-11-15 15:52 | cth103 | File Added: 2913.patch | |
| 2009-11-15 15:52 | cth103 | Status | new => assigned |
| 2009-11-15 15:52 | cth103 | Assigned To | => paul |
| 2009-11-15 15:52 | cth103 | cost | => 0.00 |
| 2009-11-15 15:52 | cth103 | Summary | adding plugins to pre-fader redirect becomes more slowly as more plugins are added => [PATCH] adding plugins to pre-fader redirect becomes more slowly as more plugins are added |
| 2009-11-15 15:53 | cth103 | Note Added: 0007104 | |
| 2009-11-15 22:58 | nowhiskey | Note Added: 0007106 | |
| 2009-11-16 03:03 | paul | Note Added: 0007109 | |
| 2009-11-16 12:39 | nowhiskey | Note Added: 0007118 | |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:31 | cth103 | Category | bugs2 => bugs |
| 2010-04-27 13:42 | paul | Note Added: 0007631 | |
| 2010-05-06 11:35 | nowhiskey | Note Added: 0007806 | |
| 2010-05-06 11:39 | cth103 | Note Added: 0007807 | |
| 2010-05-06 11:39 | cth103 | Status | assigned => resolved |
| 2010-05-06 11:39 | cth103 | Resolution | open => fixed |
| 2020-04-19 20:14 | system | Note Added: 0022006 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
