View Issue Details

IDProjectCategoryView StatusLast Update
0002909ardourbugspublic2020-04-19 20:14
Reporterdavepl Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0002909: Ardour version 2.8.3 E: ardour no-return-in-nonvoid-function gtk2_ardour/main.cc:274
DescriptionHi when building ardour-2.8.3 on the openSUSE build service it fails with the above error relating to :-
static gboolean
tell_about_jack_death (void* /* ignored */)
{
  if (AudioEngine::instance()->processed_frames() == 0) {
    /* died during startup */
    MessageDialog msg (_("JACK exited"), false, Gtk::MESSAGE_INFO, Gtk::BUTTONS_OK);
    msg.set_position (Gtk::WIN_POS_CENTER);
    msg.set_secondary_text (_(
                  "JACK exited unexpectedly, and without notifying Ardour.\n\
\n\
This could be due to misconfiguration or to an error inside JACK.\n\
\n\
Click OK to exit Ardour."));
    
    msg.run ();
    _exit (0);

  } else {

    /* engine has already run, so this is a mid-session JACK death */

    MessageDialog* msg = manage (new MessageDialog (_("JACK exited"), false, Gtk::MESSAGE_INFO, Gtk::BUTTONS_NONE));
    msg->set_secondary_text (_(
"JACK exited unexpectedly, and without notifying Ardour.\n\
\n\
This is probably due to an error inside JACK. You should restart JACK\n\
and reconnect Ardour to it, or exit Ardour now. You cannot save your\n\
session at this time, because we would lose your connection information.\n"));
    msg->present ();
  }
}
I simply patched in "_exit (0);" to get it to build but I don't think this is what was intended.
Additional InformationBuild flags:-
-fmessage-length=0 -O2 -fno-strict-aliasing -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g

TagsNo tags attached.

Activities

davepl

2009-11-10 10:47

reporter   ~0007096

I downloaded svn 2.0 ongoing and found the following fix :-
Index: ardour-2.8.3/gtk2_ardour/main.cc
===================================================================
--- ardour-2.8.3.orig/gtk2_ardour/main.cc
+++ ardour-2.8.3/gtk2_ardour/main.cc
@@ -270,6 +270,8 @@ This is probably due to an error inside
 and reconnect Ardour to it, or exit Ardour now. You cannot save your\n\
 session at this time, because we would lose your connection information.\n"));
     msg->present ();
+ return false; /* do not call again */
+
   }
 }

cth103

2009-11-10 13:20

administrator   ~0007097

Reporter says this is resolved in 2.0-ongoing.

system

2020-04-19 20:14

developer   ~0022003

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2009-11-10 10:06 davepl New Issue
2009-11-10 10:47 davepl Note Added: 0007096
2009-11-10 13:20 cth103 cost => 0.00
2009-11-10 13:20 cth103 Note Added: 0007097
2009-11-10 13:20 cth103 Status new => resolved
2009-11-10 13:20 cth103 Resolution open => fixed
2009-11-10 13:20 cth103 Assigned To => cth103
2010-04-24 10:28 cth103 Category bugs => bugs2
2010-04-24 10:31 cth103 Category bugs2 => bugs
2020-04-19 20:14 system Note Added: 0022003
2020-04-19 20:14 system Status resolved => closed