View Issue Details

IDProjectCategoryView StatusLast Update
0002907ardourbugspublic2020-04-19 20:14
Reporternickm Assigned Topaul  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product VersionSVN/2.0-ongoing 
Summary0002907: [PATCH] 6042 crashes in gtk2_ardour/gain_meter.cc::GainMeter::meter_metrics_expose
Descriptionardour segfaults on line 888:

        static Glib::RefPtr<Gtk::Style> meter_style;
        if (style_changed) {
                meter_style = meter_metric_area.get_style();
        }
        Glib::RefPtr<Gdk::Window> win (meter_metric_area.get_window());
        Glib::RefPtr<Gdk::GC> bg_gc (meter_style->get_bg_gc (Gtk::STATE_INSENSITIVE));

If style_changed is false then dereferencing meter_style results in a segfault. Changing the code to

        static Glib::RefPtr<Gtk::Style> meter_style;
        meter_style = meter_metric_area.get_style();
        Glib::RefPtr<Gdk::Window> win (meter_metric_area.get_window());
        Glib::RefPtr<Gdk::GC> bg_gc (meter_style->get_bg_gc (Gtk::STATE_INSENSITIVE));

fixes the problem but I'm not sure if this is the correct fix!
TagsNo tags attached.

Activities

2009-11-09 19:19

 

gain_meter_backtrace.log (11,387 bytes)

paul

2010-09-13 16:26

administrator   ~0009037

this was solved independently by some very related changes to the meter expose function. i wish i'd noticed this report sononer, especially since i had assigned it to myself!

system

2020-04-19 20:14

developer   ~0022001

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2009-11-09 19:16 nickm New Issue
2009-11-09 19:19 nickm File Added: gain_meter_backtrace.log
2009-11-09 23:49 cth103 cost => 0.00
2009-11-09 23:49 cth103 Assigned To => paul
2009-11-09 23:49 cth103 Status new => assigned
2009-11-09 23:49 cth103 Summary 6042 crashes in gtk2_ardour/gain_meter.cc::GainMeter::meter_metrics_expose => [PATCH] 6042 crashes in gtk2_ardour/gain_meter.cc::GainMeter::meter_metrics_expose
2010-04-24 10:28 cth103 Category bugs => bugs2
2010-04-24 10:31 cth103 Category bugs2 => bugs
2010-09-13 16:26 paul Note Added: 0009037
2010-09-13 16:26 paul Status assigned => resolved
2010-09-13 16:26 paul Resolution open => fixed
2020-04-19 20:14 system Note Added: 0022001
2020-04-19 20:14 system Status resolved => closed