View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002796 | ardour | bugs | public | 2009-07-27 19:21 | 2020-04-19 20:14 |
| Reporter | nickm | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002796: [PATCH] Allow edit group visibility to be saved in the session | ||||
| Description | At the moment 2.0-ongoing doesn't save the Hidden flag for edit groups. It also uses an obscure (as in it has no UI as far as I can tell) configuration option to disable edit groups when they are hidden. This patch addresses both these issues. Patch against 2.0-ongoing rev 5424. | ||||
| Tags | No tags attached. | ||||
|
2009-07-27 19:21
|
2.0-ongoing-edit-group-tickboxes-5424.patch (1,549 bytes)
Index: 2.0-ongoing-edit-group-tickboxes/gtk2_ardour/editor_edit_groups.cc
===================================================================
--- 2.0-ongoing-edit-group-tickboxes/gtk2_ardour/editor_edit_groups.cc (revision 5424)
+++ 2.0-ongoing-edit-group-tickboxes/gtk2_ardour/editor_edit_groups.cc (working copy)
@@ -208,8 +208,10 @@
bool active = (*iter)[group_columns.is_active];
group->set_active (active, this);
+
+ bool visible = (*iter)[group_columns.is_visible];
+ group->set_hidden (!visible, this);
-
string name = (*iter)[group_columns.text];
if (name != group->name()) {
@@ -225,7 +227,7 @@
TreeModel::Row row = *(group_model->append());
row[group_columns.is_active] = group->is_active();
- row[group_columns.is_visible] = false;
+ row[group_columns.is_visible] = !group->is_hidden();
in_edit_group_row_change = true;
Index: 2.0-ongoing-edit-group-tickboxes/libs/ardour/route_group.cc
===================================================================
--- 2.0-ongoing-edit-group-tickboxes/libs/ardour/route_group.cc (revision 5424)
+++ 2.0-ongoing-edit-group-tickboxes/libs/ardour/route_group.cc (working copy)
@@ -188,14 +188,8 @@
}
if (yn) {
_flags = Flag (_flags | Hidden);
- if (Config->get_hiding_groups_deactivates_groups()) {
- _flags = Flag (_flags & ~Active);
- }
} else {
_flags = Flag (_flags & ~Hidden);
- if (Config->get_hiding_groups_deactivates_groups()) {
- _flags = Flag (_flags | Active);
- }
}
_session.set_dirty ();
FlagsChanged (src); /* EMIT SIGNAL */
|
|
|
Assigned to Paul to take a look at the patch. Seablade |
|
|
committed to 2.0-ongoing. something similar needed in 3.0 but the code and even concepts are a bit different there now. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-07-27 19:21 | nickm | New Issue | |
| 2009-07-27 19:21 | nickm | File Added: 2.0-ongoing-edit-group-tickboxes-5424.patch | |
| 2009-08-11 07:11 | seablade | Status | new => assigned |
| 2009-08-11 07:11 | seablade | Assigned To | => paul |
| 2009-08-11 07:11 | seablade | Note Added: 0006502 | |
| 2009-10-01 17:50 | paul | cost | => 0.00 |
| 2009-10-01 17:50 | paul | Note Added: 0006672 | |
| 2009-10-01 17:50 | paul | Status | assigned => resolved |
| 2009-10-01 17:50 | paul | Resolution | open => fixed |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:31 | cth103 | Category | bugs2 => bugs |
| 2020-04-19 20:14 | system | Note Added: 0021961 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |