View Issue Details

IDProjectCategoryView StatusLast Update
0002788ardourbugspublic2020-04-19 20:14
Reporterelthariel Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformLinux 2.6 
Summary0002788: Double clicks on region in editor causes segfault
DescriptionAs said here: http://library.gnome.org/devel/gdk/stable/gdk-Event-Structures.html#GdkEventButton
When double clicking, in addition to GDK_BUTTON_EVENT, GTK_{2/3}BUTTON_EVENT are emitted by GDK, but for the 2 events, only one release is called. In button_press_handler this cause _drag object to be created without being deleted in the release handler, triggering asserting

GDK_2BUTTON_EVENT and GDK_3BUTTON_EVENT doesn't appears anywhere in the button click handler so i think we can simply discard them for the moment.
Steps To ReproduceDouble click on a region in the editor
TagsNo tags attached.

Activities

2009-07-23 00:57

 

double-click-segfault-in-editor.patch (643 bytes)   
Index: gtk2_ardour/editor_canvas_events.cc
===================================================================
--- gtk2_ardour/editor_canvas_events.cc	(revision 5415)
+++ gtk2_ardour/editor_canvas_events.cc	(working copy)
@@ -229,8 +229,6 @@
 	
 	switch (event->type) {
 	case GDK_BUTTON_PRESS:
-	case GDK_2BUTTON_PRESS:
-	case GDK_3BUTTON_PRESS:
 		ret = button_press_handler (item, event, type);
 		break;
 	case GDK_BUTTON_RELEASE:
@@ -248,6 +246,9 @@
 		ret = leave_handler (item, event, type);
 		break;
 
+	/* double and triple clicks are currently unused. */
+	case GDK_2BUTTON_PRESS:
+	case GDK_3BUTTON_PRESS:
 	default:
 		break;
 	}

cth103

2009-09-02 23:07

administrator   ~0006633

This has been fixed with a slightly modified patch. Many thanks!

system

2020-04-19 20:14

developer   ~0021956

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2009-07-23 00:57 elthariel New Issue
2009-07-23 00:57 elthariel File Added: double-click-segfault-in-editor.patch
2009-07-23 01:01 cth103 Status new => assigned
2009-07-23 01:01 cth103 Assigned To => cth103
2009-09-02 23:07 cth103 cost => 0.00
2009-09-02 23:07 cth103 Note Added: 0006633
2009-09-02 23:07 cth103 Status assigned => resolved
2009-09-02 23:07 cth103 Resolution open => fixed
2010-04-24 10:28 cth103 Category bugs => bugs2
2010-04-24 10:31 cth103 Category bugs2 => bugs
2020-04-19 20:14 system Note Added: 0021956
2020-04-19 20:14 system Status resolved => closed