View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002786 | ardour | bugs | public | 2009-07-21 22:29 | 2020-04-19 20:14 |
| Reporter | elthariel | Assigned To | paul | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0002786: ardour.menus isn't installed | ||||
| Description | It seems that waf doesn't consider install_path for this kind of objects. The rc files are correctly installed but not the menus file. This corrects the problem on my system Index: gtk2_ardour/wscript =================================================================== --- gtk2_ardour/wscript (revision 5407) +++ gtk2_ardour/wscript (working copy) @@ -372,7 +372,7 @@ obj.argv = menus_argv obj.stdin = 'ardour.menus.in' obj.stdout = 'ardour.menus' - obj.install_path = os.path.join(bld.env['CONFIGDIR'], 'ardour3') + bld.install_files(os.path.join(bld.env['CONFIGDIR'], 'ardour3'), 'ardour.menus') # Keybindings keybindings_dict = {} | ||||
| Tags | install | ||||
|
2009-07-21 22:29
|
ardour.menus-installfix.patch (472 bytes)
Index: gtk2_ardour/wscript
===================================================================
--- gtk2_ardour/wscript (revision 5407)
+++ gtk2_ardour/wscript (working copy)
@@ -372,7 +372,7 @@
obj.argv = menus_argv
obj.stdin = 'ardour.menus.in'
obj.stdout = 'ardour.menus'
- obj.install_path = os.path.join(bld.env['CONFIGDIR'], 'ardour3')
+ bld.install_files(os.path.join(bld.env['CONFIGDIR'], 'ardour3'), 'ardour.menus')
# Keybindings
keybindings_dict = {}
|
|
|
This issue should be renamed to 'Install of ardour 3.0' Keyboards bindings weren't installed as well. A bigger patch is joined, it fixes the problem. |
|
2009-07-22 10:37
|
ardour3-install-fixes.patch (1,936 bytes)
[00m[37m[33m[01mIndex: gtk2_ardour/wscript[00m
[00m[37m[33m[01m===================================================================[00m
[00m[37m[33m--- gtk2_ardour/wscript (revision 5410)[00m
[00m[37m[35m+++ gtk2_ardour/wscript (working copy)[00m
[00m[37m[34m@@ -253,12 +253,12 @@[00m
obj.source += ' cocoacarbon.mm '
obj.cxxflags += [ '-DTOP_MENUBAR', '-DGTKOSX' ]
obj.linkflags += [ '-framework', 'AppKit', '-framework', 'CoreAudioKit' ]
[00m[37m[33m- [00m
[00m[37m[35m+[00m
if bld.env['AUDIOUNITS']:
obj.source += ' au_pluginui.mm '
obj.cxxflags += [ '-DHAVE_AUDIOUNITS' ]
obj.uselib_local += ' libappleutility '
[00m[37m[33m- [00m
[00m[37m[35m+[00m
else:
obj.source += ' x11.cc '
[00m[37m[34m@@ -372,7 +372,7 @@[00m
obj.argv = menus_argv
obj.stdin = 'ardour.menus.in'
obj.stdout = 'ardour.menus'
[00m[37m[33m- obj.install_path = os.path.join(bld.env['CONFIGDIR'], 'ardour3')[00m
[00m[37m[35m+ bld.install_files(os.path.join(bld.env['CONFIGDIR'], 'ardour3'), 'ardour.menus')[00m
# Keybindings
keybindings_dict = {}
[00m[37m[34m@@ -392,9 +392,10 @@[00m
for b in [ 'SAE-de-keypad', 'SAE-de-nokeypad', 'SAE-us-keypad', 'SAE-us-nokeypad',
'mnemonic-us', 'ergonomic-us' ]:
obj = bld.new_task_gen('subst')
[00m[37m[33m- obj.target = b + '.bindings'[00m
[00m[37m[33m- obj.source = obj.target + '.in'[00m
[00m[37m[33m- obj.dict = keybindings_dict[00m
[00m[37m[35m+ obj.target = b + '.bindings'[00m
[00m[37m[35m+ obj.source = obj.target + '.in'[00m
[00m[37m[35m+ obj.dict = keybindings_dict[00m
[00m[37m[35m+ obj.install_path = os.path.join(bld.env['CONFIGDIR'], 'ardour3')[00m
# Icons/Images
bld.install_files('${DATADIR}/ardour3/icons', 'icons/*.png')
[00m[37m[34m@@ -404,3 +405,4 @@[00m
def shutdown():
autowaf.shutdown()
[00m[37m[35m+ [00m
[00m |
|
2009-07-23 01:36
|
ardour3-install-fixes-without-color-codes.patch (1,528 bytes)
Index: gtk2_ardour/wscript
===================================================================
--- gtk2_ardour/wscript (revision 5415)
+++ gtk2_ardour/wscript (working copy)
@@ -258,12 +258,12 @@
obj.source += [ 'cocoacarbon.mm' ]
obj.cxxflags += [ '-DTOP_MENUBAR', '-DGTKOSX' ]
obj.linkflags += [ '-framework', 'AppKit', '-framework', 'CoreAudioKit' ]
-
+
if bld.env['AUDIOUNITS']:
obj.source += [ 'au_pluginui.mm' ]
obj.cxxflags += [ '-DHAVE_AUDIOUNITS' ]
obj.uselib_local += ' libappleutility '
-
+
else:
obj.source += [ 'x11.cc' ]
@@ -377,7 +377,7 @@
obj.argv = menus_argv
obj.stdin = 'ardour.menus.in'
obj.stdout = 'ardour.menus'
- obj.install_path = os.path.join(bld.env['CONFIGDIR'], 'ardour3')
+ bld.install_files(os.path.join(bld.env['CONFIGDIR'], 'ardour3'), 'ardour.menus')
# Keybindings
keybindings_dict = {}
@@ -397,9 +397,10 @@
for b in [ 'SAE-de-keypad', 'SAE-de-nokeypad', 'SAE-us-keypad', 'SAE-us-nokeypad',
'mnemonic-us', 'ergonomic-us' ]:
obj = bld.new_task_gen('subst')
- obj.target = b + '.bindings'
- obj.source = obj.target + '.in'
- obj.dict = keybindings_dict
+ obj.target = b + '.bindings'
+ obj.source = obj.target + '.in'
+ obj.dict = keybindings_dict
+ obj.install_path = os.path.join(bld.env['CONFIGDIR'], 'ardour3')
# Icons/Images
bld.install_files('${DATADIR}/ardour3/icons', 'icons/*.png')
@@ -415,3 +416,4 @@
def i18n(bld):
build_i18n (bld, 'gtk2_ardour', APPNAME, gtk2_ardour_sources)
+
|
|
|
Assigned to Paul to take a look at the patch. |
|
|
patch applied to my code and committed, rev: 5416. thanks! (oh, and elthariel, a real name would be useful for the contributors list) |
|
|
The name was added tot he Mantis profile. Resolving issue. Seablade |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-07-21 22:29 | elthariel | New Issue | |
| 2009-07-21 22:29 | elthariel | File Added: ardour.menus-installfix.patch | |
| 2009-07-22 10:33 | elthariel | Tag Attached: install | |
| 2009-07-22 10:36 | elthariel | Note Added: 0006452 | |
| 2009-07-22 10:37 | elthariel | File Added: ardour3-install-fixes.patch | |
| 2009-07-23 01:36 | elthariel | File Added: ardour3-install-fixes-without-color-codes.patch | |
| 2009-07-23 02:01 | seablade | Status | new => assigned |
| 2009-07-23 02:01 | seablade | Assigned To | => paul |
| 2009-07-23 02:01 | seablade | Note Added: 0006453 | |
| 2009-07-23 03:03 | paul | Note Added: 0006457 | |
| 2009-07-23 17:54 | seablade | cost | => 0.00 |
| 2009-07-23 17:54 | seablade | Note Added: 0006460 | |
| 2009-07-23 17:54 | seablade | Status | assigned => resolved |
| 2009-07-23 17:54 | seablade | Fixed in Version | => SVN 3.0 |
| 2009-07-23 17:54 | seablade | Resolution | open => fixed |
| 2020-04-19 20:14 | system | Note Added: 0021955 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
