View Issue Details

IDProjectCategoryView StatusLast Update
0002775ardourfeaturespublic2020-04-19 20:14
Reporternedko Assigned Topaul  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Product Version2.8.1 
Summary0002775: [PATCH] add missing support for lv2 epp:logarithmic
DescriptionThe extension is defined here: http://lv2plug.in/docs/index.php?title=Extended_port_information

naspro uses them. calf uses them. latest git swh uses them (the gate plugin)
Additional InformationThe attached patch that fixes the issue for me.
TagsNo tags attached.

Activities

2009-07-12 00:28

 

ardour-2.8.1-lv2-epp-logarithmic.patch (1,645 bytes)   
commit 449a43b8182f0bf2690b7e3d706cb050e0a1f78a
Author: Nedko Arnaudov <nedko@arnaudov.name>
Date:   Fri Jun 19 21:14:21 2009 +0300

    lv2: Add support for epp:logarithmic

diff --git a/libs/ardour/ardour/lv2_plugin.h b/libs/ardour/ardour/lv2_plugin.h
index de8eb61..47436cf 100644
--- a/libs/ardour/ardour/lv2_plugin.h
+++ b/libs/ardour/ardour/lv2_plugin.h
@@ -159,6 +159,7 @@ struct LV2World {
 	SLV2Value toggled;
 	SLV2Value srate;
 	SLV2Value gtk_gui;
+	SLV2Value logarithmic;
 };
 
 
diff --git a/libs/ardour/lv2_plugin.cc b/libs/ardour/lv2_plugin.cc
index 10648c3..31e868f 100644
--- a/libs/ardour/lv2_plugin.cc
+++ b/libs/ardour/lv2_plugin.cc
@@ -346,7 +346,7 @@ LV2Plugin::get_parameter_descriptor (uint32_t which, ParameterDescriptor& desc)
 	
     desc.integer_step = slv2_port_has_property(_plugin, port, _world.integer);
     desc.toggled = slv2_port_has_property(_plugin, port, _world.toggled);
-    desc.logarithmic = false; // TODO (LV2 extension)
+    desc.logarithmic = slv2_port_has_property(_plugin, port, _world.logarithmic);
     desc.sr_dependent = slv2_port_has_property(_plugin, port, _world.srate);
     desc.label = slv2_value_as_string(slv2_port_get_name(_plugin, port));
     desc.lower = min ? slv2_value_as_float(min) : 0.0f;
@@ -552,6 +552,7 @@ LV2World::LV2World()
 	toggled = slv2_value_new_uri(world, SLV2_NAMESPACE_LV2 "toggled");
 	srate = slv2_value_new_uri(world, SLV2_NAMESPACE_LV2 "sampleRate");
 	gtk_gui = slv2_value_new_uri(world, "http://lv2plug.in/ns/extensions/ui#GtkUI");
+	logarithmic = slv2_value_new_uri(world, "http://lv2plug.in/ns/dev/extportinfo#logarithmic");
 }
 
 LV2World::~LV2World()

nettings

2009-08-15 02:46

manager   ~0006540

looks like this hasn't been committed or reviewed as of r5499...

nettings

2009-08-16 12:27

manager   ~0006557

the patch conflicts with nedko's external UI patch, but it's trivial to massage in by hand.
i wonder: what is it supposed to do? when i try the am pitchshifter from swh-lv2, the pitch parameter moves linearly from 0.25 to 4. and i don't see any actual functional code in the patch - what am i missing?

on a related note, lv2 plugins don't display sample-rate dependent parameters in a natural fashion. the corresponding ladspa versions give a value in hertz, whereas the lv2 ones are usually 0 .. 0.5.

nettings

2009-08-16 12:52

manager   ~0006558

sorry, turns out i was using an older swh-lv2 release. patch works for me here.
please review and apply.

paul

2009-10-01 16:32

administrator   ~0006668

committed to 2.0-ongoing and 3.0

system

2020-04-19 20:14

developer   ~0021951

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2009-07-12 00:28 nedko New Issue
2009-07-12 00:28 nedko File Added: ardour-2.8.1-lv2-epp-logarithmic.patch
2009-07-20 15:42 paul Status new => assigned
2009-07-20 15:42 paul Assigned To => paul
2009-08-15 02:46 nettings cost => 0.00
2009-08-15 02:46 nettings Note Added: 0006540
2009-08-15 02:46 nettings Severity minor => trivial
2009-08-15 02:46 nettings Category bugs => features
2009-08-15 02:46 nettings Summary missing support for lv2 epp:logarithmic => [PATCH] add missing support for lv2 epp:logarithmic
2009-08-16 12:27 nettings Note Added: 0006557
2009-08-16 12:52 nettings Note Added: 0006558
2009-10-01 16:32 paul Note Added: 0006668
2009-10-01 16:32 paul Status assigned => resolved
2009-10-01 16:32 paul Resolution open => fixed
2020-04-19 20:14 system Note Added: 0021951
2020-04-19 20:14 system Status resolved => closed