View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002761 | ardour | other | public | 2009-07-03 15:49 | 2020-04-19 20:14 |
| Reporter | tinram | Assigned To | paul | ||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Summary | 0002761: [Patch] refresh midi_port_dialog | ||||
| Description | For midi_port_dialog.cc in 3.0. It adds paddings and allows to translate "Add MIDI port" through gettext. | ||||
| Tags | No tags attached. | ||||
|
2009-07-03 15:49
|
Ardour_midi_port_dialog.patch (2,265 bytes)
*** midi_port_dialog.cc.old 2009-07-03 17:25:52.000000000 +0200
--- midi_port_dialog.cc 2009-07-03 17:43:22.000000000 +0200
***************
*** 4,9 ****
--- 4,10 ----
#include "pbd/convert.h"
#include <gtkmm2ext/utils.h>
+ #include <gtkmm2ext/window_title.h>
#include "midi_port_dialog.h"
***************
*** 18,46 ****
static const char* mode_strings[] = { "duplex", "output", "input", (char*) 0 };
MidiPortDialog::MidiPortDialog ()
! : ArdourDialog ("Add MIDI port"),
! port_label (_("Port name"))
!
{
vector<string> str = internationalize (PACKAGE, mode_strings);
set_popdown_strings (port_mode_combo, str);
port_mode_combo.set_active_text (str.front());
hpacker.pack_start (port_label);
hpacker.pack_start (port_name);
hpacker.pack_start (port_mode_combo);
- port_label.show ();
- port_name.show ();
- port_mode_combo.show ();
- hpacker.show ();
-
get_vbox()->pack_start (hpacker);
port_name.signal_activate().connect (mem_fun (*this, &MidiPortDialog::entry_activated));
add_button (Stock::CANCEL, RESPONSE_CANCEL);
add_button (Stock::ADD, RESPONSE_ACCEPT);
}
void
--- 19,56 ----
static const char* mode_strings[] = { "duplex", "output", "input", (char*) 0 };
MidiPortDialog::MidiPortDialog ()
! : ArdourDialog ("add MIDI port dialog")
! , port_label (_("Port name:"))
{
+ set_modal (true);
+ set_skip_taskbar_hint (true);
+ set_resizable (false);
+ set_position (Gtk::WIN_POS_MOUSE);
+ set_name (N_("MidiPortDialog"));
+
+ WindowTitle title(Glib::get_application_name());
+ title += _("Add MIDI port");
+ set_title(title.get_string());
+
vector<string> str = internationalize (PACKAGE, mode_strings);
set_popdown_strings (port_mode_combo, str);
port_mode_combo.set_active_text (str.front());
+ hpacker.set_spacing (6);
+ hpacker.set_border_width (5);
+
hpacker.pack_start (port_label);
hpacker.pack_start (port_name);
hpacker.pack_start (port_mode_combo);
get_vbox()->pack_start (hpacker);
port_name.signal_activate().connect (mem_fun (*this, &MidiPortDialog::entry_activated));
add_button (Stock::CANCEL, RESPONSE_CANCEL);
add_button (Stock::ADD, RESPONSE_ACCEPT);
+
+ show_all_children ();
}
void
|
|
|
Assigned to Paul to take a look at the patch. |
|
|
Applied to SVN 3.0 revision 5561. Many thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-07-03 15:49 | tinram | New Issue | |
| 2009-07-03 15:49 | tinram | File Added: Ardour_midi_port_dialog.patch | |
| 2009-07-09 03:15 | seablade | Status | new => assigned |
| 2009-07-09 03:15 | seablade | Assigned To | => paul |
| 2009-07-09 03:15 | seablade | Note Added: 0006409 | |
| 2009-08-20 21:39 | cth103 | cost | => 0.00 |
| 2009-08-20 21:39 | cth103 | Note Added: 0006580 | |
| 2009-08-20 21:39 | cth103 | Status | assigned => resolved |
| 2009-08-20 21:39 | cth103 | Fixed in Version | => SVN 3.0 |
| 2009-08-20 21:39 | cth103 | Resolution | open => fixed |
| 2020-04-19 20:14 | system | Note Added: 0021943 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |