View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002694 | ardour | bugs | public | 2009-05-25 19:20 | 2020-04-19 20:14 |
| Reporter | nickm | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002694: [PATCH] renaming a send to have the same name as a track prevents the session from being loaded again | ||||
| Description | 1. Rename a send to the same name as a track 2. Close the session 3. Load the session - ardour will give an error and refuse to load the session The attached patch (against 2.0-ongoing rev 5111) prevents a send from being given the name of an existing track | ||||
| Tags | No tags attached. | ||||
|
2009-05-25 19:20
|
2.0-ongoing-send-rename-5111.patch (637 bytes)
Index: 2.0-ongoing-send-rename/gtk2_ardour/redirect_box.cc
===================================================================
--- 2.0-ongoing-send-rename/gtk2_ardour/redirect_box.cc (revision 5111)
+++ 2.0-ongoing-send-rename/gtk2_ardour/redirect_box.cc (working copy)
@@ -920,6 +920,11 @@
case Gtk::RESPONSE_ACCEPT:
name_prompter.get_result (result);
if (result.length()) {
+ if (ARDOUR_UI::instance()->the_editor().get_named_time_axis(result) != 0) {
+ ARDOUR_UI::instance()->popup_error (_("A track already exists with that name"));
+ return;
+ }
+
redirect->set_name (result, this);
}
break; |
|
|
Patch against 5338 |
|
2009-07-08 18:06
|
2.0-ongoing-send-rename-5338.patch (638 bytes)
Index: 2.0-ongoing-send-rename/gtk2_ardour/redirect_box.cc
===================================================================
--- 2.0-ongoing-send-rename/gtk2_ardour/redirect_box.cc (revision 5338)
+++ 2.0-ongoing-send-rename/gtk2_ardour/redirect_box.cc (working copy)
@@ -920,6 +920,11 @@
case Gtk::RESPONSE_ACCEPT:
name_prompter.get_result (result);
if (result.length()) {
+ if (ARDOUR_UI::instance()->the_editor().get_named_time_axis(result) != 0) {
+ ARDOUR_UI::instance()->popup_error (_("A track already exists with that name"));
+ return;
+ }
+
redirect->set_name (result, this);
}
break;
|
|
|
Assigned to Paul to take a look at the patch. |
|
|
committed for 2.0-ongoing and 3.0, but the 2.X fix should really use Session::route_by_name() not Editor::get_named_time_axis(). |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-05-25 19:20 | nickm | New Issue | |
| 2009-05-25 19:20 | nickm | File Added: 2.0-ongoing-send-rename-5111.patch | |
| 2009-06-10 01:27 | cth103 | Relationship added | related to 0002683 |
| 2009-06-10 01:32 | cth103 | Relationship added | related to 0002474 |
| 2009-07-08 18:06 | nickm | Note Added: 0006403 | |
| 2009-07-08 18:06 | nickm | File Added: 2.0-ongoing-send-rename-5338.patch | |
| 2009-07-08 18:47 | seablade | Status | new => assigned |
| 2009-07-08 18:47 | seablade | Assigned To | => paul |
| 2009-07-08 18:48 | seablade | Note Added: 0006407 | |
| 2009-10-02 20:44 | paul | cost | => 0.00 |
| 2009-10-02 20:44 | paul | Note Added: 0006682 | |
| 2009-10-02 20:44 | paul | Status | assigned => resolved |
| 2009-10-02 20:44 | paul | Resolution | open => fixed |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:31 | cth103 | Category | bugs2 => bugs |
| 2020-04-19 20:14 | system | Note Added: 0021920 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
