View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000265 | ardour | bugs | public | 2004-02-14 03:35 | 2008-11-20 23:38 |
| Reporter | timbyr | Assigned To | taybin | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0000265: The big "editor mixer" button can be in the wrong state. | ||||
| Description | If the mixer strip in the editor is accessed using the "editor mixer" button and then the mixer strip is closed using the button in the mixerstrip then the "editor mixer" button remains in a depressed state. | ||||
| Additional Information | soooo trivial. | ||||
| Tags | No tags attached. | ||||
|
2004-07-15 17:36
|
editor_mixer_button.patch (1,924 bytes)
--- gtk_ardour/editor.cc 2004-07-05 13:25:17.000000000 -0500
+++ ../ardour.new/gtk_ardour/editor.cc 2004-07-14 14:52:57.000000000 -0500
@@ -259,6 +259,7 @@
editor_mixer_button (_("editor\nmixer")),
+
selection_start_clock (X_("SelectionStartClock"), true),
selection_end_clock (X_("SelectionEndClock"), true),
edit_cursor_clock (X_("EditCursorClock"), false),
@@ -3001,6 +3002,10 @@
// toolbar_clock_vbox.set_spacing (2);
// toolbar_clock_vbox.set_border_width (10);
+ /* the editor/mixer button will be enabled at session connect */
+
+ editor_mixer_button.set_active(false);
+ editor_mixer_button.set_sensitive(false);
HBox* hbox = new HBox;
--- gtk_ardour/editor_mixer.cc 2004-06-28 12:31:43.000000000 -0500
+++ ../ardour.new/gtk_ardour/editor_mixer.cc 2004-07-14 11:15:51.000000000 -0500
@@ -247,7 +247,11 @@
selection_end_clock.set_session (0);
zoom_range_clock.set_session (0);
nudge_clock.set_session (0);
-
+
+ /* put editor/mixer toggle button in off position and disable until a new session is loaded */
+
+ editor_mixer_button.set_active(false);
+ editor_mixer_button.set_sensitive(false);
/* clear tempo/meter rulers */
remove_metric_marks ();
--- gtk_ardour/editor_route_list.cc 2004-06-26 19:28:34.000000000 -0500
+++ ../ardour.new/gtk_ardour/editor_route_list.cc 2004-07-14 11:15:51.000000000 -0500
@@ -76,6 +76,9 @@
route.gui_changed.connect (slot (*this, &Editor::handle_gui_changes));
tv->GoingAway.connect (bind (slot (*this, &Editor::remove_route), tv));
+
+ editor_mixer_button.set_sensitive(true);
+
}
void
@@ -102,6 +105,16 @@
break;
}
}
+ /* since the editor mixer goes away when you remove a route, set the
+ * button to inacttive
+ */
+ editor_mixer_button.set_active(false);
+
+ /* and disable if all tracks and/or routes are gone */
+
+ if (track_views.size() == 0) {
+ editor_mixer_button.set_sensitive(false);
+ }
}
void
|
|
|
Here's a patch that fixes the problem. |
|
|
You can also do this if you delete the track when it is being shown. |
|
|
The patch here fixes that problem as well I believe. |
|
|
Thanks for the patch. It looks good. |
|
|
Thanks, I've applied the patch to my tree. |
|
|
Removing a *track* doesn't mean my wish to have a mixerstrip in the editor has changed. User expresses that wish by pressing/depressing the editor-mixer button or "x" on the strip. On removing a track I'd prefer the strip to change to either master or a surrounding track and for the sake of it change to none when there is no track left. I think this mantis should really be called "The left hand side of the editor can be in the wrong state". |
|
|
Applied and committed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2004-02-14 03:35 | timbyr | New Issue | |
| 2004-07-15 17:36 | Jeff | File Added: editor_mixer_button.patch | |
| 2004-07-15 17:36 | Jeff | Note Added: 0001227 | |
| 2004-07-25 04:57 | sharp | Note Added: 0001268 | |
| 2004-07-26 17:15 | Jeff | Note Added: 0001281 | |
| 2004-07-26 17:38 | taybin | Note Added: 0001283 | |
| 2004-07-31 00:09 | taybin | Note Added: 0001315 | |
| 2004-08-14 10:00 | tito | Note Added: 0001410 | |
| 2004-08-17 00:56 | taybin | Status | new => resolved |
| 2004-08-17 00:56 | taybin | Resolution | open => fixed |
| 2004-08-17 00:56 | taybin | Assigned To | => taybin |
| 2004-08-17 00:56 | taybin | Note Added: 0001411 | |
| 2008-11-20 23:38 | seablade | Status | resolved => closed |
