View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002581 | ardour | bugs | public | 2009-03-06 18:39 | 2020-04-19 20:13 |
| Reporter | mtaht | Assigned To | paul | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002581: More fit and finish issues - universal set_popdown_strings descenders not handled cleanly. | ||||
| Description | After looking at the code for a while, I can see no cases where the typical (and often absent) pairing of Gtkmm2ext::set_size_request_to_display_given_text (edit_mode_selector, edit_mode_strings, 7+FUDGE, 10); set_popdown_strings (edit_mode_selector, edit_mode_strings); could not be replaced wholesale with, declaring set_popdown_strings to take an optional FUDGE and spacing argument, and doing all the work in that one call site. The existing permutations of FUDGE+X seem rather arbitrary. I also discovered an easily compensated for bug in the set_size_request code(s) If the translated strings do not contain a descender character, like "g", the total height of the combo box is calculated to be shorter. While this is correct behavior I think the boxes look better if they are all the same height. (I ran into this while trying to shrink the size of the import dialog to something sane in spanish) I do not know if other languages have bigger descenders than "g". I tend to think that recalculating "g" every **** time would be silly, so that should get cached somewhere... | ||||
| Additional Information | It's kind of rare where I can introduce less code rather than more... | ||||
| Tags | No tags attached. | ||||
| related to | 0002565 | new | Spanish translation issues |
|
|
changes made to 2.0-ongoing ... Gtkmm2ext::set_popdown_strings() now takes 3 optional arguments to say whether to size the combo plus option h- and v-padding. i notice there are lots of set_popdown_strings() that are not associated explicit sizing of a combo, and this is probably not a mistake. rev 4829. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-03-06 18:39 | mtaht | New Issue | |
| 2009-03-06 18:39 | mtaht | cost | => 0.00 |
| 2009-03-06 18:40 | mtaht | Relationship added | related to 0002565 |
| 2009-03-13 13:01 | paul | Status | new => resolved |
| 2009-03-13 13:01 | paul | Resolution | open => fixed |
| 2009-03-13 13:01 | paul | Assigned To | => paul |
| 2009-03-13 13:01 | paul | Note Added: 0005818 | |
| 2020-04-19 20:13 | system | Note Added: 0021878 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |
