View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002573 | ardour | bugs | public | 2009-02-26 15:38 | 2020-04-19 20:13 |
| Reporter | seanbutnotheard | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.7.1 | ||||
| Summary | 0002573: [PATCH] ctrl+button2 drag in lock mode creates unusable regions | ||||
| Description | in lock edit mode, a "ctrl+button2 drag" exhibits the following behavior: -the region does not initially appear to be duplicated, but the duplicate is actually just unmovable until the button is released -after duplicating the region, the duplicate can be moved but does weird things (does't follow zoom changes, disappears randomly, etc.) to reproduce: -create new session -switch to lock edit mode -record a bit of audio -ctrl+button2 drag the new region -zoom in+out and try to move the resulting duplicate to see the odd effects When I initially encountered the bug, the duplicate region did not exist when I repoened the session. The work-around is to stay in "slide edit" when duplicating regions. | ||||
| Tags | No tags attached. | ||||
|
|
Confirmed, something funny is definitely going on here... |
|
|
I think some or all of these problems are fixed in 3.0 revision 5825. |
|
2009-10-20 20:49
|
2573.patch (955 bytes)
diff --git a/gtk2_ardour/editor_mouse.cc b/gtk2_ardour/editor_mouse.cc
index 1bcd75e..83bb3bd 100644
--- a/gtk2_ardour/editor_mouse.cc
+++ b/gtk2_ardour/editor_mouse.cc
@@ -3727,12 +3727,7 @@ Editor::region_drag_motion_callback (ArdourCanvas::Item* item, GdkEvent* event)
bool x_move_allowed;
if (Config->get_edit_mode() == Lock) {
- if (drag_info.copy) {
- x_move_allowed = !drag_info.x_constrained;
- } else {
- /* in locked edit mode, reverse the usual meaning of x_constrained */
- x_move_allowed = drag_info.x_constrained;
- }
+ x_move_allowed = drag_info.x_constrained;
} else {
x_move_allowed = !drag_info.x_constrained;
}
@@ -3979,7 +3974,7 @@ Editor::region_drag_finished_callback (ArdourCanvas::Item* item, GdkEvent* event
the drag.
*/
- if (Config->get_edit_mode() == Lock && !drag_info.copy) {
+ if (Config->get_edit_mode() == Lock) {
drag_info.x_constrained = !drag_info.x_constrained;
}
|
|
|
The attached patch should improve things on 2.8.x / 2.0 SVN, if you'd like to test it? |
|
|
Tested and committed to 2.8.3 SVN |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-02-26 15:38 | seanbutnotheard | New Issue | |
| 2009-10-20 20:16 | cth103 | Note Added: 0006784 | |
| 2009-10-20 20:16 | cth103 | Status | new => confirmed |
| 2009-10-20 20:43 | cth103 | Note Added: 0006786 | |
| 2009-10-20 20:49 | cth103 | File Added: 2573.patch | |
| 2009-10-20 20:50 | cth103 | Note Added: 0006787 | |
| 2009-10-20 20:50 | cth103 | Status | confirmed => assigned |
| 2009-10-20 20:50 | cth103 | Assigned To | => paul |
| 2009-10-20 20:50 | cth103 | cost | => 0.00 |
| 2009-10-20 20:50 | cth103 | Summary | ctrl+button2 drag in lock mode creates unusable regions => [PATCH] ctrl+button2 drag in lock mode creates unusable regions |
| 2009-10-21 16:21 | BenLoftis | Note Added: 0006844 | |
| 2009-10-22 01:57 | cth103 | Status | assigned => resolved |
| 2009-10-22 01:57 | cth103 | Resolution | open => fixed |
| 2020-04-19 20:13 | system | Note Added: 0021874 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |
