View Issue Details

IDProjectCategoryView StatusLast Update
0002567ardourbugspublic2020-04-19 20:13
Reporterlincoln Assigned Tocth103  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Summary0002567: Ardour 3 playhead does not move following click in ruler
DescriptionAt present in Ardour 3 SVN the playhead gets disabled when you click in the the ruler of ranges zone at the top of the editor. The variable pending_locate_request is not being reset to false since the signal Located was not emitted after a locate request.

The system behaved normally when synced to jack. Infact in this code path the Located signal is being emitted.

I am including a small patch to emit the Located signal in the non-jack sync path of the start_locate function. This clear the issue and the playhead is happy to function as expected following a locate operation.
TagsNo tags attached.

Activities

2009-02-24 01:51

 

ardour3-ruler-locate-fix.patch (352 bytes)   
Index: libs/ardour/session_transport.cc
===================================================================
--- libs/ardour/session_transport.cc	(revision 4650)
+++ libs/ardour/session_transport.cc	(working copy)
@@ -650,6 +650,8 @@
 	} else {
 
 		locate (target_frame, with_roll, with_flush, with_loop);
+		
+		Located (); /* EMIT SIGNAL */
 	}
 }
 

duffrecords

2009-02-24 19:30

reporter   ~0005771

I think I'm experiencing the same problem in Ardour 2 SVN (rev. 4650). If I click and hold down the mouse button on the ruler, the playhead will move to that location, but once I let go, it snaps back to the beginning of the session.

cth103

2009-02-27 23:49

administrator   ~0005779

My fault, thanks for spotting it and for the fix, applied to r.4708. This code was introduced in 3.0, so if there are similar problems with 2.0 there will be a different cause. Please could you open a new bug report if that is the case. Thanks both.

Carl

system

2020-04-19 20:13

developer   ~0021872

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2009-02-24 01:50 lincoln New Issue
2009-02-24 01:51 lincoln File Added: ardour3-ruler-locate-fix.patch
2009-02-24 19:30 duffrecords Note Added: 0005771
2009-02-27 23:49 cth103 cost => 0.00
2009-02-27 23:49 cth103 Status new => resolved
2009-02-27 23:49 cth103 Resolution open => fixed
2009-02-27 23:49 cth103 Assigned To => cth103
2009-02-27 23:49 cth103 Note Added: 0005779
2010-04-24 10:28 cth103 Category bugs => bugs2
2010-04-24 10:31 cth103 Category bugs2 => bugs
2020-04-19 20:13 system Note Added: 0021872
2020-04-19 20:13 system Status resolved => closed