View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002559 | ardour | bugs | public | 2009-02-22 16:57 | 2020-04-19 20:13 |
| Reporter | johne53 | Assigned To | paul | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.7.1 | ||||
| Summary | 0002559: Crash when hitting 'S' with mouse button held down | ||||
| Description | Select any timeline region. With the left mouse button held down, press the letter 's' on your qwerty keyboard. When you release the mouse button, Ardour immediately crashes. | ||||
| Additional Information | Have also tried this in 2.4 and the same thing happens. | ||||
| Tags | No tags attached. | ||||
|
|
Confirmed and fixed in SVN rev. 4709. Will look into a similar fix for 2.0. |
|
2009-02-28 02:19
|
split-with-mouse-held-crash.patch (1,053 bytes)
diff --git a/gtk2_ardour/editor.cc b/gtk2_ardour/editor.cc
index eee60e0..06cd719 100644
--- a/gtk2_ardour/editor.cc
+++ b/gtk2_ardour/editor.cc
@@ -855,6 +855,10 @@ Editor::catch_vanishing_regionview (RegionView *rv)
audioregionview by itself.
*/
+ if (rv->get_canvas_group() == drag_info.item) {
+ end_grab (drag_info.item, 0);
+ }
+
if (clicked_regionview == rv) {
clicked_regionview = 0;
}
diff --git a/gtk2_ardour/editor_mouse.cc b/gtk2_ardour/editor_mouse.cc
index 4228bcb..b870ea3 100644
--- a/gtk2_ardour/editor_mouse.cc
+++ b/gtk2_ardour/editor_mouse.cc
@@ -1983,9 +1983,9 @@ Editor::end_grab (ArdourCanvas::Item* item, GdkEvent* event)
return false;
}
- drag_info.item->ungrab (event->button.time);
+ drag_info.item->ungrab (event ? event->button.time : 0);
- if (drag_info.finished_callback) {
+ if (drag_info.finished_callback && event) {
drag_info.last_pointer_x = drag_info.current_pointer_x;
drag_info.last_pointer_y = drag_info.current_pointer_y;
(this->*(drag_info.finished_callback)) (item, event);
|
|
|
Patch for 2.0-ongoing now attached. Assigning to Paul to see if he wants to apply it before the next release. |
|
|
Just confirming that I applied the Version 2.0 patch this morning and the problem is now fixed. |
|
|
patch also applied to 2.0-ongoing, for upcoming 2.0 release |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-02-22 16:57 | johne53 | New Issue | |
| 2009-02-28 01:53 | cth103 | Note Added: 0005780 | |
| 2009-02-28 01:53 | cth103 | Status | new => acknowledged |
| 2009-02-28 02:19 | cth103 | File Added: split-with-mouse-held-crash.patch | |
| 2009-02-28 02:20 | cth103 | Status | acknowledged => assigned |
| 2009-02-28 02:20 | cth103 | Assigned To | => paul |
| 2009-02-28 02:20 | cth103 | Note Added: 0005781 | |
| 2009-03-17 09:01 | johne53 | Note Added: 0005826 | |
| 2009-03-17 09:02 | johne53 | Note Edited: 0005826 | |
| 2009-03-24 14:19 | paul | cost | => 0.00 |
| 2009-03-24 14:19 | paul | Status | assigned => resolved |
| 2009-03-24 14:19 | paul | Resolution | open => fixed |
| 2009-03-24 14:19 | paul | Note Added: 0005844 | |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:31 | cth103 | Category | bugs2 => bugs |
| 2020-04-19 20:13 | system | Note Added: 0021868 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |