View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002558 | ardour | bugs | public | 2009-02-22 01:55 | 2020-04-19 20:13 |
| Reporter | lincoln | Assigned To | drobilla | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0002558: Crash in end_rubber_band_select | ||||
| Description | Ardour 3.0 is crashing in the following scenario: 1. set undo history to 1 2. rubber band select a region I have traced this to editor_mouse.cc end_rubber_band_select. What is happening is that there are nested reversible commands (end_rubber_band_select and select_all_within) on the editor state. When commiting the reversable command in end_rubber_band_select the is a null property at the end of the session state and a crash occurs. I think the reason for this is that the session begin XMLNode is being clobbered by the second begin_reverible_command in select_all_within which also oprtates on the session state. This seems wrong to me. Removing the begin/commit reversible command pair in select_all_within fixes the crashing behaviour | ||||
| Additional Information | Fixed in r5051. | ||||
| Tags | No tags attached. | ||||
|
2009-05-03 20:23
|
region-select-crash.patch (556 bytes)
Index: gtk2_ardour/editor_selection.cc
===================================================================
--- gtk2_ardour/editor_selection.cc (revision 5023)
+++ gtk2_ardour/editor_selection.cc (working copy)
@@ -1016,7 +1016,7 @@
}
}
- begin_reversible_command (_("select all within"));
+ //begin_reversible_command (_("select all within"));
switch (op) {
case Selection::Add:
selection->add (touched);
@@ -1032,7 +1032,7 @@
break;
}
- commit_reversible_command ();
+ //commit_reversible_command ();
return !touched.empty();
}
|
|
|
Uploaded a test patch for this issue. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-02-22 01:55 | lincoln | New Issue | |
| 2009-05-03 20:23 | lincoln | File Added: region-select-crash.patch | |
| 2009-05-03 20:23 | lincoln | Note Added: 0005969 | |
| 2009-05-05 01:53 | drobilla | Status | new => assigned |
| 2009-05-05 01:53 | drobilla | Assigned To | => drobilla |
| 2009-05-05 01:54 | drobilla | cost | => 0.00 |
| 2009-05-05 01:54 | drobilla | Status | assigned => resolved |
| 2009-05-05 01:54 | drobilla | Resolution | open => fixed |
| 2009-05-05 01:54 | drobilla | Additional Information Updated | |
| 2020-04-19 20:13 | system | Note Added: 0021867 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |
