View Issue Details

IDProjectCategoryView StatusLast Update
0002487ardourbugspublic2020-04-19 20:13
Reporterpeppot Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSVN/2.0-ongoing 
Summary0002487: Mute (m) does not operate on multiple selected regions
DescriptionMute (m) does not operate on multiple selected regions
In mouse mode, it only operates on the currently hovered over region.
On all selected regions would make more sense and be consistent with other similar region operations.
TagsNo tags attached.

Activities

2008-12-14 23:38

 

mute-selection.patch (1,360 bytes)   
diff -r 3403830e2065 gtk2_ardour/editor_keyboard.cc
--- a/gtk2_ardour/editor_keyboard.cc	Sun Dec 14 23:33:44 2008 +0000
+++ b/gtk2_ardour/editor_keyboard.cc	Sun Dec 14 23:35:08 2008 +0000
@@ -78,7 +78,28 @@
 void
 Editor::kbd_mute_unmute_region ()
 {
-	if (entered_regionview) {
+	if (!selection->regions.empty ()) {
+
+		if (selection->regions.size() > 1) {
+			begin_reversible_command (_("mute regions"));
+		} else {
+			begin_reversible_command (_("mute region"));
+		}
+
+		for (RegionSelection::iterator i = selection->regions.begin(); i != selection->regions.end(); ++i) {
+
+			XMLNode &before = (*i)->region()->playlist()->get_state ();
+			(*i)->region()->set_muted (!(*i)->region()->muted ());
+			XMLNode &after = (*i)->region()->playlist()->get_state ();
+
+			session->add_command (new MementoCommand<ARDOUR::Playlist>(*((*i)->region()->playlist()), &before, &after));
+
+		}
+
+		commit_reversible_command ();
+
+	} else if (entered_regionview) {
+		
 		begin_reversible_command (_("mute region"));
 		XMLNode &before = entered_regionview->region()->playlist()->get_state();
 		
@@ -87,6 +108,7 @@
 		XMLNode &after = entered_regionview->region()->playlist()->get_state();
 		session->add_command (new MementoCommand<ARDOUR::Playlist>(*(entered_regionview->region()->playlist()), &before, &after));
 		commit_reversible_command();
+		
 	}
 }
 
mute-selection.patch (1,360 bytes)   

cth103

2008-12-14 23:41

administrator   ~0005521

Thanks for the report!

The attached patch changes things so that if there are selected regions, they are muted, otherwise the one under the mouse is muted. This makes more sense, I think. Although it's not clear what's best for the case when there are selected regions, but the mouse is over an unselected one.

peppot

2008-12-15 12:15

reporter   ~0005524

Tried the patch; works very good! Thanks. Should be applied IMO

cth103

2008-12-17 00:36

administrator   ~0005530

Thanks for testing! Applied to 3.0.

peppot

2008-12-18 11:14

reporter   ~0005535

Any chance of a 2.0-ongoing commit? Sorry about reopening but couldn't find your e-mail, Carl.

cth103

2008-12-18 13:16

administrator   ~0005537

No problems, I'll leave that up to Paul.

paul

2009-03-13 12:12

administrator   ~0005815

hmm, already applied to 2.0-ongoing. not sure when i did that but i suppose its all good.

system

2020-04-19 20:13

developer   ~0021839

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2008-12-10 22:18 peppot New Issue
2008-12-14 23:38 cth103 File Added: mute-selection.patch
2008-12-14 23:41 cth103 Note Added: 0005521
2008-12-15 01:41 cth103 Status new => feedback
2008-12-15 12:15 peppot Note Added: 0005524
2008-12-17 00:36 cth103 cost => 0.00
2008-12-17 00:36 cth103 Status feedback => resolved
2008-12-17 00:36 cth103 Fixed in Version => SVN 3.0
2008-12-17 00:36 cth103 Resolution open => fixed
2008-12-17 00:36 cth103 Assigned To => cth103
2008-12-17 00:36 cth103 Note Added: 0005530
2008-12-18 11:14 peppot Status resolved => feedback
2008-12-18 11:14 peppot Resolution fixed => reopened
2008-12-18 11:14 peppot Note Added: 0005535
2008-12-18 13:16 cth103 Note Added: 0005537
2008-12-18 13:16 cth103 Status feedback => assigned
2008-12-18 13:16 cth103 Assigned To cth103 => paul
2009-03-13 12:12 paul Status assigned => resolved
2009-03-13 12:12 paul Resolution reopened => fixed
2009-03-13 12:12 paul Note Added: 0005815
2010-04-24 10:28 cth103 Category bugs => bugs2
2010-04-24 10:31 cth103 Category bugs2 => bugs
2020-04-19 20:13 system Note Added: 0021839
2020-04-19 20:13 system Status resolved => closed