View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002475 | ardour | features | public | 2008-11-26 16:40 | 2020-04-19 20:13 |
| Reporter | ronj | Assigned To | paul | ||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002475: open the plugin manager when doubleclick on black plugin/insert/send space | ||||
| Description | Hello, Reason for this small usability suggestion: while the black spaces below and above the track levels can be used for plugins/inserts/sends, (I think) they are most of the time used for plugins. To let new users still know that this space can also contain sends and inserts, - a dialogbox could inform the user on the first doubleclick, or - an permanent note could be added at the bottom of the plugin manager | ||||
| Tags | No tags attached. | ||||
|
2008-11-29 18:22
|
dclick-plugin.patch (1,095 bytes)
diff --git a/gtk2_ardour/plugin_selector.h b/gtk2_ardour/plugin_selector.h
index c2f6576..ab5495b 100644
--- a/gtk2_ardour/plugin_selector.h
+++ b/gtk2_ardour/plugin_selector.h
@@ -46,6 +46,7 @@ class PluginSelector : public ArdourDialog
void on_show ();
Gtk::Menu& plugin_menu ();
+ void show_manager ();
private:
PluginInterestedObject* interested_object;
@@ -125,7 +126,6 @@ class PluginSelector : public ArdourDialog
void plugin_chosen_from_menu (const ARDOUR::PluginInfoPtr&);
Gtk::Menu* _menu;
- void show_manager ();
};
#endif // __ardour_plugin_selector_h__
diff --git a/gtk2_ardour/redirect_box.cc b/gtk2_ardour/redirect_box.cc
index b6c5694..2a696e2 100644
--- a/gtk2_ardour/redirect_box.cc
+++ b/gtk2_ardour/redirect_box.cc
@@ -303,6 +303,12 @@ RedirectBox::redirect_button_press_event (GdkEventButton *ev)
// this is purely informational but necessary
RedirectSelected (redirect); // emit
+
+ } else if (!redirect && ev->button == 1 && ev->type == GDK_2BUTTON_PRESS) {
+
+ choose_plugin ();
+ _plugin_selector.show_manager ();
+
}
return ret;
|
|
|
The attached patch implements this. Comments welcome. |
|
|
cth103's patch works fine. not noticed any regression: - right click still works - copying plugins from one track to another still works - double clicking on a plugin to set parameters still works |
|
|
Thanks for testing, ronj. I'll assign this to paul to see what he thinks. |
|
|
appplied the patch too and everything looks good. seems to be rather useful addiction. cheers, doc |
|
|
committed to svn, and will be in 2.7.1 |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-11-26 16:40 | ronj | New Issue | |
| 2008-11-29 18:22 | cth103 | File Added: dclick-plugin.patch | |
| 2008-11-29 18:23 | cth103 | Note Added: 0005394 | |
| 2008-12-01 14:25 | cth103 | Status | new => feedback |
| 2008-12-01 15:12 | ronj | Note Added: 0005410 | |
| 2008-12-01 15:40 | cth103 | Status | feedback => assigned |
| 2008-12-01 15:40 | cth103 | Assigned To | => paul |
| 2008-12-01 15:40 | cth103 | Note Added: 0005411 | |
| 2008-12-01 15:47 | nowhiskey | Note Added: 0005412 | |
| 2008-12-05 08:22 | paul | cost | => 0.00 |
| 2008-12-05 08:22 | paul | Status | assigned => resolved |
| 2008-12-05 08:22 | paul | Resolution | open => fixed |
| 2008-12-05 08:22 | paul | Note Added: 0005493 | |
| 2020-04-19 20:13 | system | Note Added: 0021830 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |