View Issue Details

IDProjectCategoryView StatusLast Update
0002330ardourfeaturespublic2020-04-19 20:13
Reporterkemitix Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSVN/2.0-ongoing 
Summary0002330: Can't Lock multiple Regions anymore
DescriptionI used to be able to select several regions and right-click (sub-menu) Lock. This ability has disappeared since the new Selected Regions sub-menu was added.

Could this feature be re-enabled?
TagsNo tags attached.

Activities

2008-06-25 19:49

 

lock-mute-opaque-multiple-selections.patch (781 bytes)   
Index: gtk2_ardour/editor.cc
===================================================================
--- gtk2_ardour/editor.cc	(revision 3493)
+++ gtk2_ardour/editor.cc	(working copy)
@@ -1873,6 +1873,16 @@
 				fooc.block (false);
 			}
 		}
+	} else {
+		// multiple regions selected
+		// how should these act? 
+		// here they toggle the property of all selected regions
+	
+		items.push_back (MenuElem (_("Lock"), mem_fun(*this, &Editor::toggle_region_lock)));
+		items.push_back (MenuElem (_("Mute"), mem_fun(*this, &Editor::toggle_region_mute)));
+		if (!Profile->get_sae()) {
+			items.push_back (MenuElem (_("Opaque"), mem_fun(*this, &Editor::toggle_region_opaque)));
+		}
 	}
 
 	items.push_back (CheckMenuElem (_("Original position"), mem_fun(*this, &Editor::naturalize)));

colinf

2008-06-25 19:53

updater   ~0005078

How about this patch (lock-mute-opaque-multiple-selections.patch).

With this, "Lock" will toggle the locked state of all the selected regions. There's no tick mark in the menu to indicate the current locked state now, though, even if all the selected regions are locked: that would be a bit more difficult.

kemitix

2008-06-25 20:06

reporter   ~0005079

That works for me.

Thanks. :)

paul

2008-06-26 01:54

administrator   ~0005080

applied and committed as part of rev 3495. thanks as usual.

system

2020-04-19 20:13

developer   ~0021767

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2008-06-25 18:43 kemitix New Issue
2008-06-25 19:49 colinf File Added: lock-mute-opaque-multiple-selections.patch
2008-06-25 19:53 colinf Note Added: 0005078
2008-06-25 20:06 kemitix Note Added: 0005079
2008-06-26 01:54 paul cost => 0.00
2008-06-26 01:54 paul Status new => resolved
2008-06-26 01:54 paul Resolution open => fixed
2008-06-26 01:54 paul Assigned To => paul
2008-06-26 01:54 paul Note Added: 0005080
2020-04-19 20:13 system Note Added: 0021767
2020-04-19 20:13 system Status resolved => closed