View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002260 | ardour | bugs | public | 2008-05-20 14:25 | 2020-04-19 20:13 |
| Reporter | peppot | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002260: "h", Height button on pan and fader automation track is confused with track height | ||||
| Description | "h", Height button on pan and fader automation track is confused with track height Enable a pan or fader automation for a track, and try to set its height with the "h" button/selector on the automation track. Result: it changes the track/waveform's height, not the automation track. | ||||
| Tags | No tags attached. | ||||
|
2008-05-23 17:40
|
automation-track-height.patch (3,169 bytes)
Index: gtk2_ardour/automation_time_axis.cc
===================================================================
--- gtk2_ardour/automation_time_axis.cc (revision 3408)
+++ gtk2_ardour/automation_time_axis.cc (working copy)
@@ -52,7 +52,6 @@
route (r),
_name (nom),
_state_name (state_name),
- height_button (_("h")),
clear_button (_("clear")),
auto_button (X_("")) /* force addition of a label */
{
@@ -87,14 +86,12 @@
hide_button.add (*(manage (new Gtk::Image (::get_icon("hide")))));
- height_button.set_name ("TrackSizeButton");
auto_button.set_name ("TrackVisualButton");
clear_button.set_name ("TrackVisualButton");
hide_button.set_name ("TrackRemoveButton");
controls_table.set_no_show_all();
- ARDOUR_UI::instance()->tooltips().set_tip(height_button, _("track height"));
ARDOUR_UI::instance()->tooltips().set_tip(auto_button, _("automation state"));
ARDOUR_UI::instance()->tooltips().set_tip(clear_button, _("clear track"));
ARDOUR_UI::instance()->tooltips().set_tip(hide_button, _("hide track"));
@@ -155,14 +152,12 @@
/* add the buttons */
controls_table.attach (hide_button, 0, 1, 0, 1, Gtk::FILL|Gtk::EXPAND, Gtk::FILL|Gtk::EXPAND);
- controls_table.attach (height_button, 0, 1, 1, 2, Gtk::FILL|Gtk::EXPAND, Gtk::FILL|Gtk::EXPAND);
controls_table.attach (auto_button, 5, 8, 0, 1, Gtk::FILL|Gtk::EXPAND, Gtk::FILL|Gtk::EXPAND);
controls_table.attach (clear_button, 5, 8, 1, 2, Gtk::FILL|Gtk::EXPAND, Gtk::FILL|Gtk::EXPAND);
controls_table.show_all ();
- height_button.signal_clicked().connect (mem_fun(*this, &AutomationTimeAxisView::height_clicked));
clear_button.signal_clicked().connect (mem_fun(*this, &AutomationTimeAxisView::clear_clicked));
hide_button.signal_clicked().connect (mem_fun(*this, &AutomationTimeAxisView::hide_clicked));
auto_button.signal_clicked().connect (mem_fun(*this, &AutomationTimeAxisView::auto_clicked));
@@ -283,12 +278,6 @@
}
void
-AutomationTimeAxisView::height_clicked ()
-{
- popup_size_menu (0);
-}
-
-void
AutomationTimeAxisView::clear_clicked ()
{
_session.begin_reversible_command (_("clear automation"));
@@ -302,7 +291,7 @@
AutomationTimeAxisView::set_height (uint32_t h)
{
bool changed = (height != (uint32_t) h);
- bool changed_between_small_and_normal = ( (h == hSmall || h == hSmaller) ^ (height == hSmall || height == hSmaller) );
+ bool changed_between_small_and_normal = ((h < hSmall && height >= hSmall) || (h >= hSmall || height < hSmall));
TimeAxisView* state_parent = get_parent_with_state ();
XMLNode* xml_node = state_parent->get_child_xml_node (_state_name);
@@ -325,7 +314,7 @@
if (changed_between_small_and_normal || first_call_to_set_height) {
first_call_to_set_height = false;
- if (h >= hNormal) {
+ if (h >= hSmaller) {
controls_table.remove (name_hbox);
if (plugname) {
@@ -344,7 +333,6 @@
name_hbox.show_all ();
auto_button.show();
- height_button.show();
clear_button.show();
hide_button.show_all();
@@ -363,7 +351,6 @@
name_hbox.show_all ();
auto_button.hide();
- height_button.hide();
clear_button.hide();
hide_button.hide();
}
|
|
|
Here's a patch to remove the (now redundant) track height buttons from automation tracks. It also fixes the behaviour that once an automation track is shrunk with the 'handle' so that the controls disappear, they wouldn't re-appear when the track was stretched up again. |
|
|
Please don't remove the "h" buttons. In a moderately complex session, the scroll wheel is unbearably slow and the context menu takes longer than a simple button. |
|
|
Sorry! I was going on the fact that they've already gone from the main tracks, which I assume is because there's now a "handle" to drag the track height up & down. I don't know whether that's what's planned for automation tracks: I suppose there are plenty of other possibilities... |
|
|
You are right. I guess this patch is good then... I'll settle with using context menus :) Sorry =) |
|
|
Assigned to Paul to check the patch. Seablade |
|
|
patch committed somewhere near rev 4250. will be in 2.7.1 |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-05-20 14:25 | peppot | New Issue | |
| 2008-05-23 17:40 | colinf | File Added: automation-track-height.patch | |
| 2008-05-23 17:42 | colinf | Note Added: 0004959 | |
| 2008-05-23 17:43 | peppot | Note Added: 0004960 | |
| 2008-05-24 17:06 | colinf | Note Added: 0004961 | |
| 2008-05-25 11:50 | peppot | Note Added: 0004962 | |
| 2008-11-24 08:53 | seablade | Assigned To | => paul |
| 2008-11-24 08:53 | seablade | Status | new => assigned |
| 2008-11-24 09:12 | seablade | Note Added: 0005302 | |
| 2008-11-24 09:35 | seablade | Relationship added | has duplicate 0002340 |
| 2008-11-26 21:38 | paul | cost | => 0.00 |
| 2008-11-26 21:38 | paul | Status | assigned => resolved |
| 2008-11-26 21:38 | paul | Resolution | open => fixed |
| 2008-11-26 21:38 | paul | Note Added: 0005381 | |
| 2020-04-19 20:13 | system | Note Added: 0021734 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |