View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002240 | ardour | bugs | public | 2008-05-08 08:50 | 2020-04-19 20:13 |
| Reporter | SaBer | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002240: start and end markers don't "work" after undoing marker moves (patch included) | ||||
| Description | Steps to reproduce: 1. move the start/end marker 2. undo 3. a) locate to start/end - doesn't work b) play until end marker is reached - playing will not stop, or the marker will not be reached | ||||
| Additional Information | Reason for bug: When undoing, ARDOUR::Session::locations()->set_state is called from MementoCommand. Locations::changed() is sent and ARDOUR::Session::handle_locations_changed is eventually called, but it does not handle the changing of start and end locations. This is fixed in the attached patch. | ||||
| Tags | No tags attached. | ||||
|
2008-05-08 08:50
|
start_end_update.diff (391 bytes)
Index: libs/ardour/session.cc
===================================================================
--- libs/ardour/session.cc (revision 3326)
+++ libs/ardour/session.cc (working copy)
@@ -1253,6 +1253,12 @@
set_loop = true;
}
+ if (location->is_start()) {
+ start_location = location;
+ }
+ if (location->is_end()) {
+ end_location = location;
+ }
}
if (!set_loop) {
|
|
|
hallo, i tested the patch with svn@3329 and it works pretty good here. at least the issue you are describing is resolved. there is one more ugly thing, which is really minor and appears not always: -open new session -locate to end marker -now move the end marker a few sec's to the right -press play - the PH moves until it reaches the marker and stops than -now pres ctrl+z - the marker goes back to the 5min's position, and the playhead is 'behind' the end marker -now put the mouse somewhere before the end marker (b.e. 4:55) -press 'p' - the playhead is not moving to the mouse position. sometimes this is working and sometimes it is not working here. i don't know and can't find out on which this is depending. cheers, doc |
|
|
committed about a week ago. thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-05-08 08:50 | SaBer | New Issue | |
| 2008-05-08 08:50 | SaBer | File Added: start_end_update.diff | |
| 2008-05-09 11:47 | nowhiskey | Note Added: 0004921 | |
| 2008-05-15 15:06 | paul | Status | new => resolved |
| 2008-05-15 15:06 | paul | Resolution | open => fixed |
| 2008-05-15 15:06 | paul | Assigned To | => paul |
| 2008-05-15 15:06 | paul | Note Added: 0004936 | |
| 2020-04-19 20:13 | system | Note Added: 0021724 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |
