View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002203 | ardour | bugs | public | 2008-04-18 09:38 | 2020-04-19 20:13 |
| Reporter | jdlv | Assigned To | paul | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002203: Plugins affects only one channel | ||||
| Description | Inserting a plugin like parametrics equalizer or a gate on a stereo Track/Bus affects only the right channel. Inserting a second (or more) plugin on the same track/bus makes the first ones behaves normally. Only the last one works only for the right channel. Issue seen on 2.4.1 and SVN/2.0-ongoing rev 3257 | ||||
| Tags | No tags attached. | ||||
|
|
i can confirm this behaviour and would really love to see a fix :-D |
|
|
I also confirm this problem, in 2.4.1 (running Debian Lenny) |
|
|
on multichannel tracks, plugins only work on the first channel ... |
|
|
git-bisect showed, that the bug was introduced in svn revision 3144 |
|
2008-04-24 18:41
|
0001-possible-fix-for-bug-no-2203.patch (1,421 bytes)
From 4d65fab78f6cab45909e422fa4a3af8dad9b57ac Mon Sep 17 00:00:00 2001
From: Tim Blechmann <tim@klingt.org>
Date: Thu, 24 Apr 2008 20:40:33 +0200
Subject: [PATCH] possible fix for bug no 2203
---
libs/ardour/route.cc | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/libs/ardour/route.cc b/libs/ardour/route.cc
index dcf78b5..478b385 100644
--- a/libs/ardour/route.cc
+++ b/libs/ardour/route.cc
@@ -862,14 +862,6 @@ Route::add_redirect (boost::shared_ptr<Redirect> redirect, void *src, uint32_t*
boost::shared_ptr<PluginInsert> pi;
boost::shared_ptr<PortInsert> porti;
- _redirects.push_back (redirect);
-
- if (_reset_plugin_counts (err_streams)) {
- _redirects.pop_back ();
- _reset_plugin_counts (0); // it worked before we tried to add it ...
- return -1;
- }
-
uint32_t potential_max_streams = 0;
if ((pi = boost::dynamic_pointer_cast<PluginInsert>(redirect)) != 0) {
@@ -910,6 +902,14 @@ Route::add_redirect (boost::shared_ptr<Redirect> redirect, void *src, uint32_t*
_max_peak_power.push_back(-INFINITY);
}
+ _redirects.push_back (redirect);
+
+ if (_reset_plugin_counts (err_streams)) {
+ _redirects.pop_back ();
+ _reset_plugin_counts (0); // it worked before we tried to add it ...
+ return -1;
+ }
+
redirect->activate ();
redirect->active_changed.connect (mem_fun (*this, &Route::redirect_active_proxy));
}
--
1.5.5
|
|
|
the attached patch is a possible fix for this bug ... it reverts a change from 3143 to 3144, that caused the bug ... it is largely untested, so i am not sure, if it introduced a new bug |
|
|
fixed in rev 3285. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-04-18 09:38 | jdlv | New Issue | |
| 2008-04-22 22:17 | nettings | Note Added: 0004893 | |
| 2008-04-24 03:31 | dcsimon | Note Added: 0004895 | |
| 2008-04-24 10:06 | timblech | Note Added: 0004896 | |
| 2008-04-24 12:08 | timblech | Note Added: 0004897 | |
| 2008-04-24 18:41 | timblech | File Added: 0001-possible-fix-for-bug-no-2203.patch | |
| 2008-04-24 18:43 | timblech | Note Added: 0004901 | |
| 2008-04-24 19:27 | paul | Status | new => resolved |
| 2008-04-24 19:27 | paul | Resolution | open => fixed |
| 2008-04-24 19:27 | paul | Assigned To | => paul |
| 2008-04-24 19:27 | paul | Note Added: 0004902 | |
| 2020-04-19 20:13 | system | Note Added: 0021703 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |