View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002183 | ardour | bugs | public | 2008-04-07 14:03 | 2020-04-19 20:13 |
| Reporter | jwrdegoede | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.1 | ||||
| Summary | 0002183: PATCH: session.cc, make sure _total_free_4k_blocks gets initialized | ||||
| Description | PATCH: session.cc, make sure _total_free_4k_blocks gets initialized | ||||
| Tags | No tags attached. | ||||
|
2008-04-07 14:03
|
ardour-session.cc-_total_free_4k_blocks.patch (692 bytes)
--- libs/ardour/session.cc~ 2006-04-26 08:44:34.000000000 -0700 +++ libs/ardour/session.cc 2006-05-14 09:44:33.000000000 -0700 @@ -243,7 +243,8 @@ : _engine (eng), _mmc_port (default_mmc_port), _mtc_port (default_mtc_port), - _midi_port (default_midi_port), + _midi_port (default_midi_port), + _total_free_4k_blocks (0), pending_events (2048), midi_requests (128), // the size of this should match the midi request pool size main_outs (0) @@ -291,6 +292,7 @@ _mmc_port (default_mmc_port), _mtc_port (default_mtc_port), _midi_port (default_midi_port), + _total_free_4k_blocks (0), pending_events (2048), midi_requests (16), main_outs (0) |
|
|
That patch was generated almost 2 years ago. Do you know what problem this patch was meant to address? There has been a number of releases since then with a huge amount of changes, it seems doubtful to me that it would still be relevant...? |
|
2008-04-14 11:42
|
0001-Initialize-member-of-Session-class-during-Session-co.patch (930 bytes)
From 16ab032621b034442b0c5004bb5f7a714c684f45 Mon Sep 17 00:00:00 2001
From: Tim Mayberry <mojofunk@gmail.com>
Date: Tue, 8 Apr 2008 13:14:13 +1000
Subject: [PATCH] Initialize member of Session class during Session construction, fixes bug 2183.
---
libs/ardour/session.cc | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libs/ardour/session.cc b/libs/ardour/session.cc
index 56291e9..238c9b8 100644
--- a/libs/ardour/session.cc
+++ b/libs/ardour/session.cc
@@ -282,6 +282,7 @@ Session::Session (AudioEngine &eng,
diskstreams (new DiskstreamList),
routes (new RouteList),
auditioner ((Auditioner*) 0),
+ _total_free_4k_blocks (0),
_click_io ((IO*) 0),
main_outs (0)
{
@@ -344,6 +345,7 @@ Session::Session (AudioEngine &eng,
midi_requests (16),
diskstreams (new DiskstreamList),
routes (new RouteList),
+ _total_free_4k_blocks (0),
main_outs (0)
{
--
1.5.4.1
|
|
|
When that patch was written I wasn't the ardour maintainer in Fedora, so I have no idea what this patch was supposed to fix. |
|
|
I've attached the patch against 2.0-ongoing@3229 that avoids compiler warnings about constructor initialization order. |
|
|
applied. thanks, and sorry for any delay. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-04-07 14:03 | jwrdegoede | New Issue | |
| 2008-04-07 14:03 | jwrdegoede | File Added: ardour-session.cc-_total_free_4k_blocks.patch | |
| 2008-04-14 11:41 | timbyr | Note Added: 0004857 | |
| 2008-04-14 11:42 | timbyr | File Added: 0001-Initialize-member-of-Session-class-during-Session-co.patch | |
| 2008-04-14 11:44 | jwrdegoede | Note Added: 0004858 | |
| 2008-04-14 11:46 | timbyr | Note Added: 0004859 | |
| 2008-04-21 12:48 | paul | Status | new => resolved |
| 2008-04-21 12:48 | paul | Resolution | open => fixed |
| 2008-04-21 12:48 | paul | Assigned To | => paul |
| 2008-04-21 12:48 | paul | Note Added: 0004885 | |
| 2020-04-19 20:13 | system | Note Added: 0021692 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |
