View Issue Details

IDProjectCategoryView StatusLast Update
0001919ardourbugspublic2008-11-21 00:04
Reportergellyfish Assigned Topaul  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version2.0 
Summary0001919: '+' is not valid in XML element name
DescriptionHi,
Will fail to load to a session if a plugin is added with a '+' in the name (simulated with xmllint):

foo.xml:2: parser error : error parsing attribute name
 <Redirect-C__Scape___Stereo_delay_+_Filters-1 track_height="normal"/>
                                   ^
foo.xml:2: parser error : attributes construct error
 <Redirect-C__Scape___Stereo_delay_+_Filters-1 track_height="normal"/>
                                   ^
foo.xml:2: parser error : Couldn't find end of Start Tag Redirect-C__Scape___Stereo_delay_ line 2
 <Redirect-C__Scape___Stereo_delay_+_Filters-1 track_height="normal"/>

I've attached the no-brainer patch.

BTW it says "duplicated in midi_time_axis.cc" in a comment but it doesn't actually appear to be there (in trunk).



TagsNo tags attached.

Activities

2007-10-12 11:27

 

ard_xml.patch (475 bytes)   
Index: route_time_axis.cc
===================================================================
--- route_time_axis.cc	(revision 2544)
+++ route_time_axis.cc	(working copy)
@@ -1490,7 +1490,7 @@
 legalize_for_xml_node (string str)
 {
 	string::size_type pos;
-	string legal_chars = "abcdefghijklmnopqrtsuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_+=:";
+	string legal_chars = "abcdefghijklmnopqrtsuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_=:";
 	string legal;
 
 	legal = str;
ard_xml.patch (475 bytes)   

paul

2007-10-17 15:26

administrator   ~0004476

thanks, patch applied to my trunk + 2.0-ongoing codebases.

Issue History

Date Modified Username Field Change
2007-10-12 11:27 gellyfish New Issue
2007-10-12 11:27 gellyfish File Added: ard_xml.patch
2007-10-17 15:26 paul Status new => resolved
2007-10-17 15:26 paul Resolution open => fixed
2007-10-17 15:26 paul Assigned To => paul
2007-10-17 15:26 paul Note Added: 0004476
2008-11-21 00:04 seablade Status resolved => closed