View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001894ardourbugspublic2007-09-28 18:542008-11-21 00:04
Reporternowhiskey Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version2.0 
Summary0001894: bad size of the 'choose click' dialog
Descriptionthis is a report on svn-ongoing-rev2496 (think that is actually 2.1)
if i 'ctrl+o', choose 'click' tab and go browsing for a click file or an emphasis file, the window is just to small for the fader to fit in.

since this is one of the windows which do not have a decoration in fluxbox, a cannot change the size until i press 'ctrl+F12' twice to toggle on the deco.
once the deco toggled on, it will not be remembered, when i open the dialog the next time in the same running session (see bug0001858).

i am not sure if this is an ardour bug, or if it is related to fluxbox i am using (v-1.0rc3).

attached is a screenshot which discribes better what i mean.

cheers,
doc

cheers,
doc
TagsNo tags attached.

Activities

2007-09-28 18:54

 

choose-click.png (96,259 bytes)   
choose-click.png (96,259 bytes)   

nowhiskey

2007-09-28 22:52

reporter   ~0004436

ok, i menaged now with the help on IRC#fluxbox to manipulate the code of fluxbox and recompiled FB again, so i can save decoration and size with the 'remember' function.

the both lines i had to remove where:

 if (winclient.transientFor())
        return;

in the /src/Remember.cc file.

after recompiling, the mostly dialogs works good, except 'big clock' and 'about' window. they do not remember decoration nor size.

as i could find out, this issue is somehow related to 0001531, but that is too much for me to understand in the moment.
the question for me still is: is this an ardour or an FB issue?
and another one - in what the 'big clock' and the 'about' windows are different as the others (import, new track ...).

cheers,
doc

jdavisp3

2007-10-26 03:25

reporter   ~0004508

I get the same problem in 2.0-ongoing and trunk.

I think this is due to the dialog explicitly making a size request instead of letting gtk choose the size. I don't see why it needs to do that. I'm going to
attach a patch, could you try it out? It fixed the problem for me.

2007-10-26 03:26

 

1894.patch (482 bytes)    
Index: gtk2_ardour/sfdb_ui.cc
===================================================================
--- gtk2_ardour/sfdb_ui.cc	(revision 2575)
+++ gtk2_ardour/sfdb_ui.cc	(working copy)
@@ -934,7 +934,6 @@
 SoundFileChooser::SoundFileChooser (Gtk::Window& parent, string title, ARDOUR::Session* s)
 	: SoundFileBrowser (parent, title, s, false)
 {
-	set_size_request (780, 300);
 	chooser.set_select_multiple (false);
 	found_list_view.get_selection()->set_mode (SELECTION_SINGLE);
 }
1894.patch (482 bytes)   

nowhiskey

2007-10-26 09:54

reporter   ~0004509

Last edited: 2007-10-26 09:55

 patch applied to ongoing-rev2575 - works much better and the window size is ok now. thanks for the patch!

cheers,
doc

cth103

2007-11-05 17:00

administrator   ~0004545

Applied to trunk and 2.0-ongoing. Many thanks for the report and the patch!

Issue History

Date Modified Username Field Change
2007-09-28 18:54 nowhiskey New Issue
2007-09-28 18:54 nowhiskey File Added: choose-click.png
2007-09-28 22:52 nowhiskey Note Added: 0004436
2007-10-26 03:25 jdavisp3 Note Added: 0004508
2007-10-26 03:26 jdavisp3 File Added: 1894.patch
2007-10-26 09:54 nowhiskey Note Added: 0004509
2007-10-26 09:55 nowhiskey Note Edited: 0004509
2007-11-05 17:00 cth103 Status new => resolved
2007-11-05 17:00 cth103 Resolution open => fixed
2007-11-05 17:00 cth103 Assigned To => cth103
2007-11-05 17:00 cth103 Note Added: 0004545
2008-11-21 00:04 seablade Status resolved => closed