View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001877 | ardour | bugs | public | 2007-09-19 11:31 | 2008-11-21 00:04 |
| Reporter | timbyr | Assigned To | timbyr | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.0 | ||||
| Summary | 0001877: OK and cancel buttons are in wrong position in duplicate region dialog | ||||
| Description | The OK button is on the left and Cancel is on the right. This is the opposite button placement to the other dialogs in ardour and caused me to hit the Cancel button by mistake. | ||||
| Tags | No tags attached. | ||||
|
2007-09-20 12:12
|
duplicate_region_button_order.patch (433 bytes)
diff --git a/gtk2_ardour/editor.cc b/gtk2_ardour/editor.cc index 2abeabb..7d51736 100644 --- a/gtk2_ardour/editor.cc +++ b/gtk2_ardour/editor.cc @@ -2969,8 +2969,8 @@ Editor::duplicate_dialog (bool dup_region) label.show (); spinner.show (); - win.add_button (Stock::OK, RESPONSE_ACCEPT); win.add_button (Stock::CANCEL, RESPONSE_CANCEL); + win.add_button (Stock::OK, RESPONSE_ACCEPT); win.set_position (WIN_POS_MOUSE); |
|
|
I've attached a patch against 2.0-ongoing@2470 to change the button order. I'll commit it in a few days if there isn't any negative feedback. |
|
|
Patch applied to trunk@2651 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-09-19 11:31 | timbyr | New Issue | |
| 2007-09-20 12:12 | timbyr | File Added: duplicate_region_button_order.patch | |
| 2007-09-20 12:12 | timbyr | Status | new => assigned |
| 2007-09-20 12:12 | timbyr | Assigned To | => timbyr |
| 2007-09-20 12:14 | timbyr | Note Added: 0004381 | |
| 2007-09-20 12:14 | timbyr | Status | assigned => feedback |
| 2007-11-13 13:22 | timbyr | Status | feedback => resolved |
| 2007-11-13 13:22 | timbyr | Resolution | open => fixed |
| 2007-11-13 13:22 | timbyr | Note Added: 0004564 | |
| 2008-11-21 00:04 | seablade | Status | resolved => closed |